Merged
Conversation
sylvestre
reviewed
Dec 26, 2024
sylvestre
reviewed
Dec 26, 2024
Contributor
|
Great start. Could you please add tests? |
Contributor
Author
Yes, any advice? |
Collaborator
|
And also, more unit tests would be better. If it cannot run on Windows, you can disable it for Windows simply. eg. #[cfg(target_os = "linux")]
#[test]
fn test_something() {
...
}At least you can write unit tests about parsing arguments? |
Krysztal112233
approved these changes
Jan 6, 2025
Collaborator
|
Could you please fix the CI failures? |
Collaborator
|
I think this file will help you to be compatible with macOS and other *NIX implementations. https://github.com/uutils/coreutils/blob/main/src/uucore/src/lib/features/signals.rs The Windows implementation much different with *NIX implementation, so you can simply disable it. #[cfg(target_family = "unix")]#[cfg(target_family = "unix")]
fn do_something(){}
#[cfg(not(target_family = "unix"))]
fn do_something(){} |
Collaborator
|
Behavior seems doesn't match |
Krysztal112233
requested changes
Jan 9, 2025
Comment on lines
+96
to
+117
| #[cfg(unix)] | ||
| let sig_num = if let Some(signal) = obs_signal { | ||
| signal | ||
| } else if let Some(signal) = matches.get_one::<String>("signal") { | ||
| parse_signal_value(signal)? | ||
| } else { | ||
| 15_usize //SIGTERM | ||
| }; | ||
|
|
||
| #[cfg(unix)] | ||
| let sig_name = signal_name_by_value(sig_num); | ||
| // Signal does not support converting from EXIT | ||
| // Instead, nix::signal::kill expects Option::None to properly handle EXIT | ||
| #[cfg(unix)] | ||
| let sig: Option<Signal> = if sig_name.is_some_and(|name| name == "EXIT") { | ||
| None | ||
| } else { | ||
| let sig = (sig_num as i32) | ||
| .try_into() | ||
| .map_err(|e| std::io::Error::from_raw_os_error(e as i32))?; | ||
| Some(sig) | ||
| }; |
Comment on lines
+140
to
+143
| #[cfg(unix)] | ||
| let echo = matches.get_flag("echo"); | ||
| #[cfg(unix)] | ||
| kill(&pids, sig, echo); |
Collaborator
There was a problem hiding this comment.
same, or a function
Collaborator
|
fells confusing, the implementation should be correct but the behavior not. could you give some help? @sylvestre @cakebaker |
Contributor
do you have details ? |
Collaborator
Here's the details |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
===========================
===========================
☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#27