tar: replace all string-based error variants with structured types#149
Merged
Conversation
a211137 to
3ea85f2
Compare
Every TarError variant now carries PathBuf and/or io::Error data instead of a pre-formatted String. Add thiserror derive macros so Display implementations are generated from #[error(...)] attributes in one central place. Eliminates the last generic TarOperation and InvalidArchive string variants.
3ea85f2 to
5b1fe91
Compare
kevinburke
reviewed
Apr 4, 2026
kevinburke
reviewed
Apr 4, 2026
kevinburke
reviewed
Apr 4, 2026
kevinburke
approved these changes
Apr 4, 2026
…t isn't used yet.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #149 +/- ##
=========================================
+ Coverage 0 63.57% +63.57%
=========================================
Files 0 7 +7
Lines 0 755 +755
Branches 0 24 +24
=========================================
+ Hits 0 480 +480
- Misses 0 275 +275
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every TarError variant now carries PathBuf and/or io::Error data instead of a pre-formatted String. Add thiserror derive macros so Display implementations are generated from #[error(...)] attributes in one central place. Eliminates the last generic TarOperation and InvalidArchive string variants.