Skip to content

util: fix GNU test result artifacts#305

Open
kevinburke wants to merge 1 commit into
uutils:mainfrom
kevinburke:fix-gnu-json-results
Open

util: fix GNU test result artifacts#305
kevinburke wants to merge 1 commit into
uutils:mainfrom
kevinburke:fix-gnu-json-results

Conversation

@kevinburke

Copy link
Copy Markdown
Contributor

GNU tar emits Autotest result lines with dotted test numbers and records failures in the detailed failure section. The previous extractor only matched an older colon-based format, so CI uploaded an empty gnu-full-result.json while still exiting successfully.

The aggregate step also called analyze-gnu-results.py with -o and a single input file, but the script only wrote the requested output in the multi-input path. Parse GNU tar's current result lines, fail loudly when extraction finds no results, and always write the requested aggregate output.

GNU tar emits Autotest result lines with dotted test numbers and
records failures in the detailed failure section. The previous
extractor only matched an older colon-based format, so CI uploaded an
empty gnu-full-result.json while still exiting successfully.

The aggregate step also called analyze-gnu-results.py with -o and a
single input file, but the script only wrote the requested output
in the multi-input path. Parse GNU tar's current result lines,
fail loudly when extraction finds no results, and always write the
requested aggregate output.
@kevinburke kevinburke requested a review from kaladron as a code owner June 15, 2026 18:51
@codspeed-hq

codspeed-hq Bot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 7 untouched benchmarks


Comparing kevinburke:fix-gnu-json-results (bbc4747) with main (9dd7012)

Open in CodSpeed

@kaladron kaladron left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My biggest question is whether this should be in some common repository for uutils so that we can all benefit from the work.

@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.84%. Comparing base (791ae26) to head (bbc4747).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #305   +/-   ##
=======================================
  Coverage   96.84%   96.84%           
=======================================
  Files          11       15    +4     
  Lines        1492     1492           
  Branches       29       29           
=======================================
  Hits         1445     1445           
  Misses         46       46           
  Partials        1        1           
Flag Coverage Δ
macos_latest 96.84% <ø> (ø)
ubuntu_latest 96.84% <ø> (ø)
windows_latest 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants