fix(index): replace this.requestAnimationFrame#1
Merged
valdio merged 1 commit intovaldio:masterfrom Aug 7, 2019
shubhamdeol:master
Merged
fix(index): replace this.requestAnimationFrame#1valdio merged 1 commit intovaldio:masterfrom shubhamdeol:master
valdio merged 1 commit intovaldio:masterfrom
shubhamdeol:master
Conversation
Replace this.requestAnimationFrame with request animation frame as **requestAnimationFrame** is globally available in react native. requestAnimationFrame is a polyfill from the browser, in browser as well it is scoped to window object. See here: https://stackoverflow.com/questions/51258292/use-requestanimationframe-in-react-native
Owner
|
@shubhamdeol can you provide more info about your use case in which your app crashed while using this package. |
|
Hey @valdio I am also facing the same issue, I am using ScrollableTabBar for renderTabBar. When screen orientation changes this error occurs. Please merge this PR
|
Author
|
@gamingumar using above code I stopped getting this error. You can use my fork if you want: |
Owner
|
@gamingumar @shubhamdeol. Fix applied to the new version: v.0.8.12 |
Author
|
@valdio Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My app was crashing on screen orientation change, due to
this.requestAnimationFrameSo I replaced this.requestAnimationFrame with request animation frame as requestAnimationFrame is globally available in react native.
requestAnimationFrame is a polyfill from the browser, in the browser as well it is scoped to the window object.
See here:
https://stackoverflow.com/questions/51258292/use-requestanimationframe-in-react-native