feat: ValkeyNode integration with ValkeyCluster#113
Merged
jdheyburn merged 3 commits intoMar 16, 2026
Conversation
fbf1c1a to
25f3f35
Compare
bjosv
reviewed
Mar 13, 2026
Collaborator
bjosv
left a comment
There was a problem hiding this comment.
Looks good, added some questions
sandeepkunusoth
previously approved these changes
Mar 15, 2026
Replace the Deployment-based workload model with ValkeyNode resources in the ValkeyCluster controller. The cluster controller now creates and manages ValkeyNode objects per shard, delegating pod lifecycle to the ValkeyNode controller. - Remove deployment.go and migrate logic into valkeycluster_controller.go - Update ValkeyCluster types and consolidate label generation utilities - Re-enable user ACL support for cluster mode - Add ValkeyNode e2e test suite and expand ValkeyCluster e2e coverage - Add sample configs for deployment workload type and user-provisioned clusters Also removes shortNames from CRDs until we decide what these should be Signed-off-by: Joseph Heyburn <jdheyburn@gmail.com>
4e3d107 to
dfe57b5
Compare
…/valkeynode-cluster-integration Signed-off-by: Joseph Heyburn <jdheyburn@gmail.com>
Signed-off-by: Joseph Heyburn <jdheyburn@gmail.com>
bjosv
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does not include (and will be fixed in subsequent PRs):
What this PR unblocks:
ScriptsConfigMapNameandUsersACLSecretNamefields on ValkeyNodeWhat can be improved after this PR is merged:
Below after applying config/samples/v1alpha1_valkeycluster.yaml
Deploying this yaml:
Deploys this:
And the container merge traverses to the pod (the default exporter version is 1.80.0):