Skip to content

pulls out all 9.1 configs by immutable or modifiable#152

Draft
stockholmux wants to merge 1 commit into
valkey-io:mainfrom
stockholmux:config-list
Draft

pulls out all 9.1 configs by immutable or modifiable#152
stockholmux wants to merge 1 commit into
valkey-io:mainfrom
stockholmux:config-list

Conversation

@stockholmux
Copy link
Copy Markdown
Member

Related #141

Summary

This PR contains a list of configs that are immutable or modifiable. Requested in the meeting on 4/24.

Features / Behaviour Changes

n/a

Implementation

No idea if the path is remotely correct, feel free to suggest the correct location. The data was pulled out from the Valkey source config.c via a regular expression.

Limitations

n/a

Testing

n/a

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message explains what changed and why
  • n/a Tests are added or updated.
  • n/a Documentation files are updated.
  • n/a I have run pre-commit locally (pre-commit run --all-files or hooks on commit)

Signed-off-by: Kyle J. Davis <kyle.davis@percona.com>
@utdrmac
Copy link
Copy Markdown
Contributor

utdrmac commented Apr 27, 2026

What do you think of resources/ and move the readiness/liveness scripts, plus this yaml in there?

@stockholmux
Copy link
Copy Markdown
Member Author

@utdrmac resources is fine by me. What do you think about the version scoping by path? E.g. /resources/9.1/config-list.yaml

I can't decide if that is needed. In theory, each version could have more/less or even change at majors.

@daanvinken
Copy link
Copy Markdown
Contributor

Can you share the command we ran to get these?


Some entries look wrong for k8s operator context, e.g. port, bind, dir, replicaof are listed as modifiable, but should trhe operator let users change these during runtime? I think some of these may be limited by the nature of Kubernetes.

Do we need a 3rd catagory like "modifiable but operator-managed"?
We may want to solve this at a different layer, just calling it out :)

@stockholmux
Copy link
Copy Markdown
Member Author

my colleague (@martinrvisser) gave them to me in a google sheet, I just converted to YAML. I'll see if he can supply the regex.

I don't think we have to be parallel perfectly to the server because, yeah, the ones you call out shouldn't be. Maybe we just move them to whatever category makes sense for the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants