Delete old events in BeforeSuite to prevent stale event assertions#169
Merged
Conversation
Stale events from previous test runs persist on the cluster and intermittently cause event assertions to fail (e.g. StaleNodeForgotten from nodes forgotten after pod IP changes between runs). The failure depends on whether pods happened to get new IPs on recreation. Purge all events in BeforeSuite so assertions only see the current run. The previously targeted resource "valkeycluster-sample" does not exist anyway. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
sandeepkunusoth
approved these changes
May 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stale events from previous test runs persist on the cluster and intermittently cause event assertions to fail (e.g. StaleNodeForgotten from nodes forgotten after pod IP changes between runs).
The failure depends on whether pods happened to get new IPs on recreation in a previous test run.
Purge all events in BeforeSuite so assertions only see the current run.
The previously targeted resource "valkeycluster-sample" does not exist anyway.
Features / Behaviour Changes
This PR fixes the flaky e2e-test part
creates a Valkey Cluster deploymenttest in valkeycluster_test.go,in assertion "StaleNodeForgotten event should not be emitted during initial creation"
Checklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)