Fix flaky metrics exporter test by waiting for cluster Ready#173
Merged
Conversation
The metrics exporter test fetched the pod IP before the cluster reached Ready state. During initial formation the operator may update the StatefulSet spec (e.g. ACL hash annotation), causing a pod restart with a new IP. The curl then hits the stale address and times out. Wait for the ValkeyCluster to reach Ready state before fetching the pod IP, ensuring the pod is stable and no further restarts will occur. Also fetch the IP by label selector instead of requiring the pod name as an intermediate step. Signed-off-by: Björn Svensson <bjorn.a.svensson@est.tech>
jdheyburn
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The metrics exporter test fetched the pod IP before the cluster reached
Readystate.During initial formation the pod IP may change before the cluster reaches Ready state. The curl then hits the stale address and times out.
Wait for the ValkeyCluster to reach Ready state before fetching the pod IP, ensuring the pod is stable and no further restarts will occur. Also fetch the IP by label selector instead of requiring the pod name as an intermediate step.
Checklist
Before submitting the PR make sure the following are checked:
pre-commit run --all-filesor hooks on commit)