Skip to content

[fix] Switch to test-e2e context if it exists already#181

Open
jdheyburn wants to merge 2 commits into
valkey-io:mainfrom
jdheyburn:fix/switch-e2e-context
Open

[fix] Switch to test-e2e context if it exists already#181
jdheyburn wants to merge 2 commits into
valkey-io:mainfrom
jdheyburn:fix/switch-e2e-context

Conversation

@jdheyburn
Copy link
Copy Markdown
Collaborator

This PR closes <Issue #>

Summary

Currently, make test-e2e will check if it needs to create a kind cluster for e2e tests. If it doesn't exist, it uses kind to create one. Kind create cluster will switch the kubecfg context to this new cluster.

If the cluster exists, the switch does not happen, and so e2e tests are ran against the current context.

This PR will switch contexts to the e2e cluster if it exists.

Features / Behaviour Changes

N/A

Implementation

N/A

Limitations

N/A

Testing

Tested locally and validated it.

Checklist

Before submitting the PR make sure the following are checked:

  • This Pull Request is related to one issue.
  • Commit message explains what changed and why
  • Tests are added or updated.
  • Documentation files are updated.
  • I have run pre-commit locally (pre-commit run --all-files or hooks on commit)

Signed-off-by: Joseph Heyburn <jdheyburn@gmail.com>
bjosv
bjosv previously approved these changes May 14, 2026
Comment thread Makefile Outdated
Co-authored-by: Björn Svensson <bjorn.a.svensson@est.tech>
Signed-off-by: Joseph Heyburn <34041368+jdheyburn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants