(feat): EventRecorder implementation#37
Conversation
Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Looks good, added one comment.
| return err | ||
| } | ||
| } else { | ||
| return err |
There was a problem hiding this comment.
We have a ConfigMapCreationFailed, but we don't have a ServiceCreationFailed and emit it here.
Should we have one, or is this event implicit in some other way?
There was a problem hiding this comment.
Hum, or maybe we have too many events already..
https://book.kubebuilder.io/reference/raising-events#events-should-be-raised-in-certain-circumstances-only
When testing on minikube all events are noted, but on kind many are lost/rate-limited, and I guess that why the test fails intermittently. The status conditions is a better indicator for a healthy cluster.
I guess we need to investigate what level of detail we really need here.
There was a problem hiding this comment.
yeah, i will add new issue for this. we need to agree on what all events should be removed.
This PR Implements valkey-io#27 Kubernetes Event recording for the ValkeyCluster controller to improve operator visibility and debugging. Adds an EventRecorder to the reconciler and wires it via the manager, updates RBAC to allow creating/patching Events, emits Normal/Warning events at key reconciliation points (e.g., node add/join failures/success), and documents event semantics in docs/status-conditions.md. Added e2e tests for some events. facing issues with validation for all events as events are rate limited kubernetes/kubernetes#136061 (comment) --------- Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
This PR Implements valkey-io#27 Kubernetes Event recording for the ValkeyCluster controller to improve operator visibility and debugging. Adds an EventRecorder to the reconciler and wires it via the manager, updates RBAC to allow creating/patching Events, emits Normal/Warning events at key reconciliation points (e.g., node add/join failures/success), and documents event semantics in docs/status-conditions.md. Added e2e tests for some events. facing issues with validation for all events as events are rate limited kubernetes/kubernetes#136061 (comment) --------- Signed-off-by: Sandeep Kunusoth <31273507+sandeepkunusoth@users.noreply.github.com>
3 participants
This PR Implements #27 Kubernetes Event recording for the ValkeyCluster controller to improve operator visibility and debugging. Adds an EventRecorder to the reconciler and wires it via the manager, updates RBAC to allow creating/patching Events, emits Normal/Warning events at key reconciliation points (e.g., node add/join failures/success), and documents event semantics in docs/status-conditions.md.
Added e2e tests for some events. facing issues with validation for all events as events are rate limited kubernetes/kubernetes#136061 (comment)