(feat): Support Resources Configuration for ValkeyCluster (#29)#41
Merged
Conversation
6 tasks
bjosv
reviewed
Jan 14, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Nice, added some comment.
Contributor
Author
|
Thanks for taking a look at this, I've implemented the changes you suggested |
hieu2102
force-pushed
the
add-resource-config
branch
2 times, most recently
from
6f728d3 to
c2f067e
Compare
hieu2102
force-pushed
the
add-resource-config
branch
from
c2f067e to
00083cd
Compare
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
hieu2102
force-pushed
the
add-resource-config
branch
from
00083cd to
acf2ef0
Compare
… ValkeyCluster CR e2e-test Signed-off-by: hieu2102 <hieund2102@gmail.com>
Signed-off-by: hieu2102 <hieund2102@gmail.com>
sandeepkunusoth
previously approved these changes
Jan 15, 2026
bjosv
reviewed
Jan 15, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Nice! Just some nits about things that adds noise to the git history.
Signed-off-by: hieu2102 <hieund2102@gmail.com>
sandeepkunusoth
approved these changes
Jan 16, 2026
bjosv
approved these changes
Jan 16, 2026
Collaborator
bjosv
left a comment
bjosv
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements #29
Resourcesconfig to the functioncreateClusterDeployment