add startup probe to valkey containers#68
Merged
Conversation
ysqyang
force-pushed
the
startup-probe
branch
from
a026693 to
e1ab165
Compare
bjosv
approved these changes
Jan 30, 2026
| }) | ||
| } | ||
| } | ||
|
|
Collaborator
There was a problem hiding this comment.
Adding a comment that the script is run with a stubbed valkey-cli might be helpful
Comment on lines
+295
to
+296
| script := []byte("#!/bin/sh\n" + | ||
| "echo \"${VALKEY_RESPONSE:-PONG}\"\n") |
Collaborator
There was a problem hiding this comment.
An alternative is
Suggested change
| script := []byte("#!/bin/sh\n" + | |
| "echo \"${VALKEY_RESPONSE:-PONG}\"\n") | |
| script := `#!/bin/sh | |
| echo "${VALKEY_RESPONSE:-PONG}" | |
| ` |
and then []byte(script) below
added 2 commits
January 31, 2026 15:36
Signed-off-by: yang.qiu <yang.qiu@reddit.com>
Signed-off-by: yang.qiu <yang.qiu@reddit.com>
ysqyang
force-pushed
the
startup-probe
branch
from
e1ab165 to
30ea1fe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As titled. Without a startup probe, the existing liveness check can fail repeatedly and restart the container before Valkey finishes starting. This PR adds a startup probe that uses the existing
liveness-check.shwith a longer failure budget (about 150s) to allow slow boots.