Skip to content

added replication check before marking cluster ready status#87

Merged
sandeepkunusoth merged 1 commit into
valkey-io:mainfrom
sandeepkunusoth:check_replicaton_status
Feb 18, 2026
Merged

added replication check before marking cluster ready status#87
sandeepkunusoth merged 1 commit into
valkey-io:mainfrom
sandeepkunusoth:check_replicaton_status

Conversation

@sandeepkunusoth
Copy link
Copy Markdown
Member

@sandeepkunusoth sandeepkunusoth commented Feb 18, 2026

Fixes #43

Added replica status check before marking cluster ready status.

E2e tests for deleting primary is already covered as part of other PR @ysqyang So not duplicating it again.

Signed-off-by: Sandeep Kunusoth <sandeepkunsoth000@gmail.com>
Comment thread internal/controller/valkeycluster_controller.go
Copy link
Copy Markdown
Collaborator

@bjosv bjosv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread internal/controller/valkeycluster_controller.go
@sandeepkunusoth sandeepkunusoth merged commit 35e6aa7 into valkey-io:main Feb 18, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

3 participants