Cap suggested sleep time

[jmoreira-valory]

Proposed changes

Suggested sleep time may grow exponentially, causing to pass out-of-bound values to the sleep method down the call stack.

Fixes

Types of changes

What types of changes does your code introduce? (A breaking change is a fix or feature that would cause existing functionality and APIs to not work as expected.)
Put an x in the box that applies

• Non-breaking fix (non-breaking change which fixes an issue)
• Breaking fix (breaking change which fixes an issue)
• Non-breaking feature (non-breaking change which adds functionality)
• Breaking feature (breaking change which adds functionality)
• Refactor (non-breaking change which changes implementation)
• Messy (mixture of the above - requires explanation!)

Checklist

Put an x in the boxes that apply.

• I have read the CONTRIBUTING doc
• I am making a pull request against the main branch (left side). Also you should start your branch off our main.
• Lint and unit tests pass locally with my changes
• I have added tests that prove my fix is effective or that my feature works
• I have locally run AI agents that could be impacted and they do not present failures derived from my changes
• Public-facing documentation has been updated with the changes affected by this PR. Even if the provided contents are not in their final form, all significant information must be included.
• Any backwards-incompatible/breaking change has been clearly documented in the upgrading document.

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

[LOCKhart07]

Could make this configurable

[Adamantios]

Making this configurable would beat the purpose of the check.

[Adamantios]

This should be apparent to the dev setting the env vars for the sleep time. Instead, I suggest checking the backoff factor && retries in the model during the params init, warning the user, and failing early.

[jmoreira-valory]

@Adamantios even if doing like that the problem will also happen. How do you suggest to proceed?

[Adamantios]

@Adamantios even if doing like that the problem will also happen. How do you suggest to proceed?

If we were to go for that solution, this message would let the dev understand that they are using irrational values for the backoff + retries, giving them a chance to revisit and reset them.

Another option would be to go for the solution you already implemented and warn the user, e.g.:

sleep time capped to x sec