Skip to content

Avoid casting to Swift types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Anviking wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Avoid casting to Swift types #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Benchmarks/NSFoundationDarwin/Sources/main.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ extension User.Friend {

public init(json: Any) throws {
guard
let json = json as? [String: Any],
let json = json as? NSDictionary,
let id = json["id"] as? Int,
let name = json["name"] as? String
else { throw JSONError.typeMismatch }
Expand All @@ -23,7 +23,7 @@ extension User {

public init(json: Any) throws {
guard
let json = json as? [String: Any],
let json = json as? NSDictionary,
let id = json["_id"] as? String,
let index = json["index"] as? Int,
let guid = json["guid"] as? String,
Expand All @@ -45,7 +45,7 @@ extension User {
let latitude = json["latitude"] as? Double,
let longitude = json["longitude"] as? Double,
let tags = json["tags"] as? [String],
let friendsObjects = json["friends"] as? [Any],
let friendsObjects = json["friends"] as? NSArray,
//let tags = json["tags"].array?.flatMap({ $0.string }) ?? []
//let friends = try json["friends"].array?.map(Friend.init) ?? []
let greeting = json["greeting"] as? String,
Expand Down Expand Up @@ -98,7 +98,7 @@ let modelResults = try bench { bytes in
let data = Data(bytes: bytes)

let json: Any = try JSONSerialization.jsonObject(with: data)
guard let array = json as? [Any] else { fatalError() }
guard let array = json as? NSArray else { fatalError() }
_ = try array.map(User.init)
}

Expand Down