Skip to content
This repository was archived by the owner on Aug 9, 2020. It is now read-only.

WIP feat: Support custom theme#168

Open
ptbrowne wants to merge 1 commit into
vectordotdev:masterfrom
ptbrowne:support-custom-theme
Open

WIP feat: Support custom theme#168
ptbrowne wants to merge 1 commit into
vectordotdev:masterfrom
ptbrowne:support-custom-theme

Conversation

@ptbrowne
Copy link
Copy Markdown

@ptbrowne ptbrowne commented Dec 28, 2018

With this change, it is possible to use a theme :

  • From a built-in gitdocs theme (default for the moment)
  • From a npm package
  • From a local to the docs directory

To support this, the theme is resolved as early as possible either with syspath.resolve or with require.resolve.

I haven't completely tested this change (default works, custom works but I haven't tested the npm package way), I mainly want to check if this is the direction you want for the themes. What do you think ?

@ptbrowne ptbrowne force-pushed the support-custom-theme branch from fce23fd to d5ff7a0 Compare December 28, 2018 18:10
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 273

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 59.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/config.js 6 9 66.67%
Totals Coverage Status
Change from base Build 271: -0.04%
Covered Lines: 396
Relevant Lines: 686

💛 - Coveralls

@coveralls
Copy link
Copy Markdown

coveralls commented Dec 28, 2018

Pull Request Test Coverage Report for Build 274

  • 6 of 9 (66.67%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 59.919%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/utils/config.js 6 9 66.67%
Totals Coverage Status
Change from base Build 271: -0.04%
Covered Lines: 396
Relevant Lines: 686

💛 - Coveralls

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants