fix(log_to_metric transform): Use correct keys for histogram/summary#24394
Merged
thomasqueirozb merged 4 commits intovectordotdev:masterfrom Jan 28, 2026
Merged
fix(log_to_metric transform): Use correct keys for histogram/summary#24394thomasqueirozb merged 4 commits intovectordotdev:masterfrom
thomasqueirozb merged 4 commits intovectordotdev:masterfrom
Conversation
Contributor
Author
|
@pront Sorry for the direct ping, but this PR has been open for 3 weeks and you were the last one to modify this file, so I was hoping someone could take a look. Thanks! |
bruceg
approved these changes
Jan 21, 2026
Member
bruceg
left a comment
There was a problem hiding this comment.
I've searched the commit history for this transform, and it has always used these names, so this fix looks correct to me. It would be ideal to have a combined metric_to_log => log_to_metric test, preferably using proptest, to fully validate this, but that may be a little beyond the scope of this PR.
Contributor
Author
|
Thanks Bruce. I did look into what would be involved in writing an end-to-end test but I didn't see any existing examples of that for this area of the code and felt it would increase the scope of the work quite a bit to figure that out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes
log_to_metrictransform to correctly handle metrics with a value type ofMetricValue::AggregatedHistogramorMetricValue::AggregatedSummary.See #24393
Vector configuration
How did you test this PR?
Change Type
Is this a breaking change?
Does this PR include user facing changes?
no-changeloglabel to this PR.References