chore(deps): bump databend-client from 0.28.2 to 0.34.0#25304
chore(deps): bump databend-client from 0.28.2 to 0.34.0#25304dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
domain: deps
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 11c798da5a
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "databend-client" | ||
| version = "0.28.2" | ||
| version = "0.33.7" |
There was a problem hiding this comment.
Cargo.lock now pins databend-client to 0.33.7, but Cargo.toml still declares databend-client = "0.28.0" (which only allows <0.29.0 for a 0.x crate). This makes the lockfile inconsistent with the manifest and breaks reproducible builds whenever the sinks-databend dependency is resolved under --locked (for example in CI/release workflows that enable that feature), because Cargo cannot satisfy the declared version requirement from the locked package.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
6 times, most recently
from
a982f20 to
8f2b4b2
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
2 times, most recently
from
1539237 to
f5f4898
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f5f4898198
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "databend-client" | ||
| version = "0.28.2" | ||
| version = "0.33.7" |
There was a problem hiding this comment.
When this dependency bump is actually used with databend-integration-tests, the integration test helper no longer compiles: src/sinks/databend/integration_tests.rs still iterates resp.schema, but databend-client 0.33.x changed Page to expose raw_schema instead of schema (0.28.2 had schema, 0.33.7 has raw_schema). Updating the lock entry without the corresponding test change leaves the Databend integration-test feature broken once the version constraint is aligned.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
from
f5f4898 to
94bf05b
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 94bf05b7c9
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "databend-client" | ||
| version = "0.28.2" | ||
| version = "0.33.7" |
There was a problem hiding this comment.
When this bump is made usable for the sinks-databend feature, src/sinks/databend/service.rs no longer compiles because the retry logic still matches DatabendError::WithContext(boxed_error, ..) as a tuple variant. In databend-client 0.33.7, Error::WithContext is a struct variant with an inner field, whereas 0.28.2 used the tuple form; this is separate from the existing Page::raw_schema test issue and breaks the non-test Databend sink build once the manifest constraint is aligned.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
4 times, most recently
from
b3b2869 to
899b050
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 899b050713
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| ] | ||
|
|
||
| [[package]] | ||
| name = "jiff-tzdb" |
There was a problem hiding this comment.
This dependency update adds new crates (jiff-tzdb and jiff-tzdb-platform) to Cargo.lock, but LICENSE-3rdparty.csv was not regenerated and currently has no entries for those package names. In the dependency-change CI path, .github/workflows/test.yml runs make check-licenses, which invokes dd-rust-license-tool check, so this PR will fail the license check until the generated license inventory is updated and committed.
Useful? React with 👍 / 👎.
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
5 times, most recently
from
71eeab7 to
54f6da7
Compare
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
2 times, most recently
from
45a39ae to
da12ecf
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
from
da12ecf to
a3ebe00
Compare
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
from
a3ebe00 to
9fd353f
Compare
Bumps [databend-client](https://github.com/databendlabs/bendsql) from 0.28.2 to 0.34.0. - [Release notes](https://github.com/databendlabs/bendsql/releases) - [Commits](databendlabs/bendsql@v0.28.2...v0.34.0) --- updated-dependencies: - dependency-name: databend-client dependency-version: 0.33.7 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/cargo/databend-client-0.33.7
branch
from
9fd353f to
b883252
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b883252f91
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| [[package]] | ||
| name = "databend-client" | ||
| version = "0.28.2" | ||
| version = "0.34.0" |
There was a problem hiding this comment.
With the lockfile now pinning databend-client 0.34.0, APIClient::query_all takes both the SQL string and a params argument, but the existing healthcheck and Databend integration tests still call it with only the SQL at src/sinks/databend/config.rs:212 and src/sinks/databend/integration_tests.rs:92,106. Once the manifest constraint is aligned so this locked version is actually used, enabling sinks-databend or databend-integration-tests will fail to compile unless these calls pass None or the intended params value; the fresh evidence is this commit's new 0.34.0 lock entry.
Useful? React with 👍 / 👎.
Bumps databend-client from 0.28.2 to 0.34.0.
Release notes
Sourced from databend-client's releases.
... (truncated)
Commits
b43d20achore: bump version to 0.34.0 (#778)6a4e8c3fix: PUT/GET stage path handling (#777)44bb308feat: support server-side parameter binding (#762)9367734ci: skip Databend patch releases for nightly tests (#775)71fa2fefeat(python): add local embedded connection support (#766)bae64d8feat(sql): support Utf8/LargeUtf8 for Arrow variant decoding (#771)f69909eci: test with nightly (#770)5949ceefeat: support arrow_result_version. (#769)9144be3fix: compact test. (#768)78a949dfeat: map geo type to string or binary. (#767)