Handle compressed, encrypted or inside-archive PDFs#335
Open
piater wants to merge 2 commits intovedang:masterfrom
Open
Handle compressed, encrypted or inside-archive PDFs#335piater wants to merge 2 commits intovedang:masterfrom
piater wants to merge 2 commits intovedang:masterfrom
Conversation
pdf-view-mode now identifies encrypted files by file name (perhaps not ideal but this is how epa does it) and treats them as remote. Fixes: vedang#256
pdf-view--write-contents-function no longer copies the local changes directly to the destination file. Instead, it loads them into the buffer and returns nil, causing the chain of write-contents-functions to proceed. Thus, writing now is roughly the inverse of reading. Fixes: vedang#257, vedang#258
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review the changes carefully. While I did not observe any odd behavior, in
pdf-view--write-contents-functionI don't fully understand how it might happen thattempfiledoesn't exist, why its deletion must beunwind-protected, whether and whypdf-info-closeneeds to be called, and why (in the original)pdf-view--server-file-nameis reset.Fixes #256
Fixes #257
Fixes #258