feat: Group skills by plugin in 'skills list' and 'add' output#361
Merged
quuu merged 2 commits intovercel-labs:mainfrom Feb 25, 2026
Merged
Conversation
|
@dingruoqian99 is attempting to deploy a commit to the Vercel Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
quuu
force-pushed
the
feature/group-skills-by-plugin
branch
from
710f3a3 to
5126993
Compare
Collaborator
|
i think the interaactive prompt is a bit overkill, but i like the grouping! |
Contributor
Author
|
@quuu, I will keep the PR simple by only introducing the grouping. Which kind of grouping would you think is better? Option 1 - Using prefixes Option 2 - Distinct multi-select groups for grouping (note that this no longer supports "a" key for selecting all, which in my opinion is a good thing as users might want to be selective with their skill installation)
Note: Repos without groupings will still function as is. |
dingruoqian99
force-pushed
the
feature/group-skills-by-plugin
branch
from
2539ed6 to
257368f
Compare
- Replace custom searchMultiselect with p.groupMultiselect for grouped skill selection - Fall back to p.multiselect when no groups exist - Restore handleDirectUrlSkillLegacy as backwards-compatible fallback - Fix process.exit(1) unconditionally exiting when --skill flag is used - Fix strict null assertions on grouped record access - Restore 'Selected N skills' info log in handleWellKnownSkills - Remove group support from search-multiselect (only used for agent selection)
dingruoqian99
force-pushed
the
feature/group-skills-by-plugin
branch
from
257368f to
1487855
Compare
Contributor
Author
|
Hey @quuu, I've simplified the PR based on your feedback. Let me know how you feel about it! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Display installed skills grouped by their plugin name (as defined in
marketplace.jsonorplugin.json) in theskills listcommand andskills addinteractive prompts.Problem/Background
When installing skills from a large repository (like Anthropic's agent skills), skills are currently shown in a flat list. This makes it difficult to navigate and understand the available capabilities when dealing with 100+ skills.
Solution
marketplace.jsonand map skill paths to their plugin names.~/.agents/.skill-lock.json) to store thepluginNamefor each installed skill.skills listandskills addto group skills by their plugin name.p.groupMultiselectwhen plugins have groups, falls back to standardp.multiselectwhen no groups exist. No custom prompt needed for skill selection.Impact
groupMultiselect— no custom prompt complexity for skill selectionakey) is not available ingroupMultiselectbut works when falling back tomultiselect(no groups)Testing
tests/plugin-grouping.test.tsadded and passeddist.test.tsfailure unrelated to this PR)src/git.tserror unrelated to this PR)Example Output