fix: remove watcher.close and use watcher.once#34
Merged
timneutkens merged 1 commit intovercel:masterfrom Sep 12, 2017
Merged
Conversation
calling chokidar's `watch()` on a same file multiple times doesn't necessarily create multiple background watchers. These calls and `watcher.close()` calls might cause a race-condition bug that stops the seemingly newly created watcher. this fix will not remove the need to use debounce because we need to make sure multiple file changes happen simultaneously (usually due to a build pipeline) will not result in an inconsistent state.
Contributor
Contributor
Author
|
@leo can we merge this? |
Member
Contributor
Author
|
great! Can we also merge #35 before releasing? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
calling chokidar's
watch()on a same file multiple times doesn'tnecessarily create multiple background watchers. These calls and
watcher.close()calls might cause a race-condition bug that stops theseemingly newly created watcher.
this fix will not remove the need to use debounce because we need to
make sure multiple file changes happen simultaneously (usually due to a
build pipeline) will not result in an inconsistent state.