Convert ignored string to regex#54
Merged
leo merged 1 commit intovercel:masterfrom Dec 4, 2017
zigomir:patch-1
Merged
Conversation
Otherwise ignore won't work.
Contributor
|
after this PR, I think we should reserve |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm using JetBrains editor and I wanted to pass
--ignore .ideatomicro-devand it would still restart server on every focus lost of the editor. To be able to really ignore the directory we'd need to convert.ideastring into regex. This change solves my issue, but I'm not so sure about other use cases.