Conversation
|
@leerob Is anyone going through PRs on this repo? |
|
Yes, our current focus right now with |
|
All right. I'll see if I can change the target branch from master to canary 👍 |
|
Those changes have been merged into Thumbs up on this PR could be a good way to indicate how many people would like to see this feature land 👍 |
|
I see. Thank you. |
KeithBrown39423
left a comment
There was a problem hiding this comment.
After reviewing this code, I have found nothing wrong with it. It provides the ability to round using any amount and shouldn't cause any problems. I have tested this code multiple times with no error and feel there is no reason the commit not be merged to the main branch.
I had renamed the package to deploy it to my npm account. This should not be changed in the upstream.
Deleted since repository uses pnpm
|
Current conflicts have been resolved. I've also fixed some issues, having to do with the package name and lock file, since I had been using this package myself, deployed to npm. |
|
are there any updates on this? 4 years old PR with 100 lines is insane |
|
The last update to the package was 4 years ago as well. @leerob do you know who maintains this package nowadays? |
This PR enables rounding through the
roundoption.rounddefaults to true and current solutions will continue to behave the same.When
roundis set to false, all rounding is disabled.When
roundis set to a number, it is used as precision fortoFixed.