Add API alias options#490
Closed
legendecas wants to merge 1 commit into
Closed
Conversation
styfle
reviewed
Dec 4, 2019
| if (Array.isArray(aliasMap)) | ||
| alias.forEach(alias => aliasMap[alias[0]] = alias[1]); | ||
| else if (typeof alias === 'object') | ||
| Object.keys(alias).forEach(from => aliasMap[from] = alias[from]); |
Member
There was a problem hiding this comment.
Suggested change
| Object.keys(alias).forEach(from => aliasMap[from] = alias[from]); | |
| aliasMap = alias; |
I think you can avoid iteration here an assign instead
styfle
reviewed
Dec 4, 2019
Member
styfle
left a comment
There was a problem hiding this comment.
What is the use case for this? Should there be a CLI option too?
|
I'm interested in this - wondering if it would enable transpiling other packages in a yarn workspace/monorepo? For example: If the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposing
aliasoptions allowing to map one module to another and bundle the mapped module into the final archive.Rollup alternatives: https://github.com/rollup/plugins/tree/master/packages/alias
Related: #460