fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages#94082
Open
bobu-putheeckal wants to merge 1 commit into
Open
fix(eslint-plugin-next): support custom pageExtensions in no-html-link-for-pages#94082bobu-putheeckal wants to merge 1 commit into
bobu-putheeckal wants to merge 1 commit into
Conversation
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| if (dirent.isDirectory(dirPath) && !dirent.isSymbolicLink()) { | ||
| res.push(...parseUrlForPages(urlprefix + dirent.name + '/', dirPath)) | ||
| res.push( | ||
| ...parseUrlForPages( |
Contributor
There was a problem hiding this comment.
In parseUrlForAppDir, the recursive call for subdirectories incorrectly calls parseUrlForPages instead of parseUrlForAppDir, causing nested app directory routes to be parsed with pages-router logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Make
@next/next/no-html-link-for-pagesrespect customsettings.next.pageExtensionswhen discovering routes inpagesandappdirectories.Why?
Projects using custom page extensions such as
*.page.jsxwere not being recognized by the rule, so internal<a href="/">links could be missed.Closes #53473
How?
settings.next.pageExtensions.index.page.jsxroute.Testing
jest --runInBand test/unit/eslint-plugin-next/no-html-link-for-pages.test.tsgit diff --checkprettier --checkon touched files