fix(client): resolve hydration deadlock on HMR WebSocket failure#94086
Open
AryanXhauhan wants to merge 1 commit into
Open
fix(client): resolve hydration deadlock on HMR WebSocket failure#94086AryanXhauhan wants to merge 1 commit into
AryanXhauhan wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Turbopack Hydration Deadlock on HMR WebSocket Failure
Issue
React hydration hangs indefinitely in environments (like cross-origin WebViews) where the HMR WebSocket connection fails to open or is closed.
Root Cause
With Turbopack debug telemetry enabled, React enters dual-stream mode. If the HMR WebSocket connection fails to open or is terminated, the debug telemetry stream never receives its terminating chunk and remains pending indefinitely. This blocks the main server response from resolving and prevents hydration from executing.
Solution
closeAllDebugChannels()indebug-channel.tsto safely close all active debug stream writers and clear the registry.resetDebugChannelState()to clear the initial document chunks buffer.web-socket.ts:resetDebugChannelState()is invoked insideinit()prior to WebSocket creation.closeAllDebugChannels()is invoked insidehandleDisconnect()to immediately close unresolved debug streams on connection failure/disconnect.This ensures graceful degradation. If the HMR WebSocket fails or drops, active debug streams are closed and the page hydrates successfully.