fix: fix thai script diacritics (upper vowel + tone mark stacking - สระจม)#748
Open
betich wants to merge 3 commits intovercel:mainfrom
Open
fix: fix thai script diacritics (upper vowel + tone mark stacking - สระจม)#748betich wants to merge 3 commits intovercel:mainfrom
betich wants to merge 3 commits intovercel:mainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
betich
changed the title
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
betich
changed the title
Author
|
Hi @shuding, this PR fixes Thai diacritics rendering issues (upper vowel + tone mark stacking) which I encountered while using this library with Thai scripts. Would appreciate any feedback when you have time 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Thai diacritics appearing below as mentioned in #668
The code lifts Thai tone upper marks (like ้) to avoid clashing with other upper vowel marks (like ิ).
isThaiCodePoint,isThaiCombiningMark,isThaiAboveMark,isThaiToneMark) to classify Thai Unicode code points and identify combining marks and their types.translatePathfunction, simplifying and clarifying how glyph paths are shifted in the rendering process. [1] [2]