Skip to content

test(core): add closure comment in sleep test helper#1071

Merged
pranaygp merged 1 commit into
mainfrom
pgp/wait-edge-case-check
Feb 16, 2026
Merged

test(core): add closure comment in sleep test helper#1071
pranaygp merged 1 commit into
mainfrom
pgp/wait-edge-case-check

Conversation

@pranaygp
Copy link
Copy Markdown
Contributor

@pranaygp pranaygp commented Feb 16, 2026

Summary

Test plan

  • Comment-only change, no behavior change

🤖 Generated with Claude Code

Copilot AI review requested due to automatic review settings February 16, 2026 01:19
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 16, 2026

⚠️ No Changeset found

Latest commit: 6946291

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Feb 16, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
❌ ▲ Vercel Production 511 1 38 550
✅ 💻 Local Development 532 0 68 600
✅ 📦 Local Production 532 0 68 600
✅ 🐘 Local Postgres 532 0 68 600
✅ 🪟 Windows 47 0 3 50
❌ 🌍 Community Worlds 107 43 9 159
✅ 📋 Other 129 0 21 150
Total 2390 44 275 2709

❌ Failed Tests

▲ Vercel Production (1 failed)

nextjs-turbopack (1 failed):

  • error handling retry behavior workflow completes despite transient 5xx on step_completed
🌍 Community Worlds (43 failed)

turso (43 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • parallelSleepWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling retry behavior workflow completes despite transient 5xx on step_completed
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • instanceMethodStepWorkflow - instance methods with "use step" directive
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

❌ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 46 0 4
✅ example 46 0 4
✅ express 46 0 4
✅ fastify 46 0 4
✅ hono 46 0 4
❌ nextjs-turbopack 48 1 1
✅ nextjs-webpack 49 0 1
✅ nitro 46 0 4
✅ nuxt 46 0 4
✅ sveltekit 46 0 4
✅ vite 46 0 4
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 43 0 7
✅ express-stable 43 0 7
✅ fastify-stable 43 0 7
✅ hono-stable 43 0 7
✅ nextjs-turbopack-canary 47 0 3
✅ nextjs-turbopack-stable 47 0 3
✅ nextjs-webpack-canary 47 0 3
✅ nextjs-webpack-stable 47 0 3
✅ nitro-stable 43 0 7
✅ nuxt-stable 43 0 7
✅ sveltekit-stable 43 0 7
✅ vite-stable 43 0 7
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 43 0 7
✅ express-stable 43 0 7
✅ fastify-stable 43 0 7
✅ hono-stable 43 0 7
✅ nextjs-turbopack-canary 47 0 3
✅ nextjs-turbopack-stable 47 0 3
✅ nextjs-webpack-canary 47 0 3
✅ nextjs-webpack-stable 47 0 3
✅ nitro-stable 43 0 7
✅ nuxt-stable 43 0 7
✅ sveltekit-stable 43 0 7
✅ vite-stable 43 0 7
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 43 0 7
✅ express-stable 43 0 7
✅ fastify-stable 43 0 7
✅ hono-stable 43 0 7
✅ nextjs-turbopack-canary 47 0 3
✅ nextjs-turbopack-stable 47 0 3
✅ nextjs-webpack-canary 47 0 3
✅ nextjs-webpack-stable 47 0 3
✅ nitro-stable 43 0 7
✅ nuxt-stable 43 0 7
✅ sveltekit-stable 43 0 7
✅ vite-stable 43 0 7
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 47 0 3
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 0
✅ mongodb 47 0 3
✅ redis-dev 3 0 0
✅ redis 47 0 3
✅ turso-dev 3 0 0
❌ turso 4 43 3
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 43 0 7
✅ e2e-local-postgres-nest-stable 43 0 7
✅ e2e-local-prod-nest-stable 43 0 7

📋 View full workflow run


Some E2E test jobs failed:

  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 16, 2026

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 0.026s (-19.9% 🟢) 1.004s (~) 0.978s 10 1.00x
💻 Local Express 0.032s (-5.1% 🟢) 1.005s (~) 0.973s 10 1.24x
🐘 Postgres Express 0.120s (+0.6%) 1.010s (~) 0.890s 10 4.66x
🐘 Postgres Nitro 0.381s (+266.7% 🔺) 1.010s (~) 0.629s 10 14.78x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 0.559s (-54.9% 🟢) 2.587s (+6.8% 🔺) 2.028s 10 1.00x
▲ Vercel Next.js (Turbopack) 0.623s (-17.3% 🟢) 2.104s (-0.8%) 1.480s 10 1.11x
▲ Vercel Express 0.631s (+3.6%) 2.155s (-1.5%) 1.524s 10 1.13x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

workflow with 1 step

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 1.072s (-3.0%) 2.005s (~) 0.933s 10 1.00x
💻 Local Express 1.103s (~) 2.006s (~) 0.903s 10 1.03x
🐘 Postgres Nitro 2.045s (-17.5% 🟢) 2.615s (-13.3% 🟢) 0.570s 10 1.91x
🐘 Postgres Express 2.404s (~) 3.014s (~) 0.610s 10 2.24x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.268s (+1.8%) 3.486s (+19.0% 🔺) 1.218s 10 1.00x
▲ Vercel Next.js (Turbopack) 2.292s (+2.8%) 3.355s (+6.7% 🔺) 1.063s 10 1.01x
▲ Vercel Express 2.528s (+11.5% 🔺) 3.454s (+5.8% 🔺) 0.925s 10 1.11x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

workflow with 10 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 10.539s (-2.6%) 11.021s (~) 0.482s 3 1.00x
💻 Local Express 10.815s (~) 11.021s (~) 0.205s 3 1.03x
🐘 Postgres Nitro 15.113s (-25.7% 🟢) 16.049s (-23.8% 🟢) 0.937s 2 1.43x
🐘 Postgres Express 20.374s (+28.4% 🔺) 21.056s (+27.2% 🔺) 0.682s 2 1.93x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 17.460s (+1.2%) 18.842s (+2.9%) 1.382s 2 1.00x
▲ Vercel Nitro 19.223s (+5.8% 🔺) 20.876s (+10.9% 🔺) 1.654s 2 1.10x
▲ Vercel Next.js (Turbopack) 22.718s (+25.7% 🔺) 24.322s (+24.7% 🔺) 1.604s 2 1.30x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 26.759s (-2.5%) 27.051s (-3.6%) 0.292s 3 1.00x
💻 Local Express 27.459s (~) 28.050s (~) 0.591s 3 1.03x
🐘 Postgres Nitro 37.940s (-24.7% 🟢) 38.103s (-25.5% 🟢) 0.163s 2 1.42x
🐘 Postgres Express 50.189s (+33.3% 🔺) 51.125s (+34.2% 🔺) 0.936s 2 1.88x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 43.121s (+1.7%) 45.211s (+4.6%) 2.090s 2 1.00x
▲ Vercel Express 43.969s (+1.1%) 44.952s (~) 0.983s 2 1.02x
▲ Vercel Next.js (Turbopack) 44.940s (+2.5%) 46.040s (+3.0%) 1.100s 2 1.04x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 55.641s (-2.8%) 56.101s (-3.4%) 0.460s 2 1.00x
💻 Local Express 57.161s (~) 58.098s (~) 0.936s 2 1.03x
🐘 Postgres Nitro 85.558s (-14.7% 🟢) 86.215s (-14.8% 🟢) 0.657s 2 1.54x
🐘 Postgres Express 100.351s (+36.0% 🔺) 101.238s (+35.6% 🔺) 0.887s 1 1.80x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 86.650s (-1.2%) 88.056s (-0.9%) 1.405s 2 1.00x
▲ Vercel Nitro 86.734s (-1.4%) 88.146s (-1.1%) 1.413s 2 1.00x
▲ Vercel Next.js (Turbopack) 88.996s (-0.7%) 90.748s (~) 1.752s 1 1.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Promise.all with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 1.358s (-3.8%) 2.005s (~) 0.647s 15 1.00x
💻 Local Express 1.399s (-0.6%) 2.005s (~) 0.606s 15 1.03x
🐘 Postgres Express 2.325s (+4.4%) 3.014s (+12.5% 🔺) 0.688s 10 1.71x
🐘 Postgres Nitro 2.555s (+5.5% 🔺) 3.017s (~) 0.462s 10 1.88x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.358s (-2.1%) 3.515s (+13.2% 🔺) 1.156s 9 1.00x
▲ Vercel Express 2.414s (-14.9% 🟢) 3.537s (-7.7% 🟢) 1.122s 9 1.02x
▲ Vercel Next.js (Turbopack) 2.736s (-5.7% 🟢) 3.966s (+3.7%) 1.230s 8 1.16x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.all with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 2.289s (-10.8% 🟢) 3.007s (~) 0.718s 10 1.00x
💻 Local Express 2.602s (+0.9%) 3.007s (~) 0.405s 10 1.14x
🐘 Postgres Express 6.960s (-41.4% 🟢) 7.227s (-41.6% 🟢) 0.266s 5 3.04x
🐘 Postgres Nitro 8.989s (+7.4% 🔺) 9.533s (+8.6% 🔺) 0.544s 4 3.93x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.176s (+28.7% 🔺) 4.159s (+26.6% 🔺) 0.983s 8 1.00x
▲ Vercel Next.js (Turbopack) 3.282s (+9.9% 🔺) 5.071s (+31.0% 🔺) 1.789s 6 1.03x
▲ Vercel Nitro 3.321s (+27.0% 🔺) 4.525s (+33.7% 🔺) 1.204s 7 1.05x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

Promise.all with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 6.175s (-15.0% 🟢) 7.013s (-12.5% 🟢) 0.838s 5 1.00x
💻 Local Express 7.252s (-6.3% 🟢) 8.019s (~) 0.767s 4 1.17x
🐘 Postgres Express 40.078s (-21.3% 🟢) 41.109s (-19.6% 🟢) 1.031s 1 6.49x
🐘 Postgres Nitro 47.084s (+4.2%) 47.119s (+2.1%) 0.035s 1 7.63x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 4.132s (+15.1% 🔺) 5.399s (+13.7% 🔺) 1.267s 7 1.00x
▲ Vercel Nitro 4.175s (+23.0% 🔺) 5.432s (+3.8%) 1.257s 6 1.01x
▲ Vercel Next.js (Turbopack) 4.239s (-21.9% 🟢) 5.516s (-13.8% 🟢) 1.277s 7 1.03x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Promise.race with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 1.348s (-6.1% 🟢) 2.005s (~) 0.656s 15 1.00x
💻 Local Express 1.416s (-1.0%) 2.005s (~) 0.589s 15 1.05x
🐘 Postgres Express 1.998s (-5.0%) 2.682s (+3.3%) 0.685s 12 1.48x
🐘 Postgres Nitro 2.286s (+9.0% 🔺) 2.742s (+9.1% 🔺) 0.456s 11 1.70x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 2.265s (-0.6%) 3.363s (+6.4% 🔺) 1.097s 9 1.00x
▲ Vercel Nitro 2.317s (~) 3.376s (+9.7% 🔺) 1.058s 10 1.02x
▲ Vercel Express 2.374s (+6.1% 🔺) 3.575s (+14.7% 🔺) 1.201s 9 1.05x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Promise.race with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 2.432s (-9.8% 🟢) 3.007s (~) 0.575s 10 1.00x
💻 Local Express 2.648s (-2.3%) 3.007s (~) 0.359s 10 1.09x
🐘 Postgres Express 11.672s (-8.6% 🟢) 12.034s (-10.0% 🟢) 0.362s 3 4.80x
🐘 Postgres Nitro 12.567s (+5.9% 🔺) 13.374s (+8.1% 🔺) 0.807s 3 5.17x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 4.537s (+50.7% 🔺) 5.688s (+48.1% 🔺) 1.151s 6 1.00x
▲ Vercel Express 10.497s (+148.1% 🔺) 11.974s (+123.9% 🔺) 1.478s 3 2.31x
▲ Vercel Nitro 50.604s (+2011.1% 🔺) 53.201s (+1662.5% 🔺) 2.597s 1 11.15x

🔍 Observability: Next.js (Turbopack) | Express | Nitro

Promise.race with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 7.070s (-9.4% 🟢) 8.015s (~) 0.945s 4 1.00x
💻 Local Express 7.671s (-3.8%) 8.017s (-5.9% 🟢) 0.346s 4 1.09x
🐘 Postgres Nitro 49.111s (-7.1% 🟢) 49.146s (-7.5% 🟢) 0.035s 1 6.95x
🐘 Postgres Express 54.814s (+7.7% 🔺) 55.118s (+7.9% 🔺) 0.304s 1 7.75x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 3.556s (+8.4% 🔺) 4.835s (+9.4% 🔺) 1.279s 7 1.00x
▲ Vercel Nitro 14.403s (+414.5% 🔺) 15.680s (+334.1% 🔺) 1.277s 2 4.05x
▲ Vercel Express 25.072s (+390.3% 🔺) 26.842s (+335.1% 🔺) 1.770s 2 7.05x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Stream Benchmarks (includes TTFB metrics)
workflow with stream

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Nitro 0.114s (-33.4% 🟢) 1.002s (~) 0.009s (-19.3% 🟢) 1.014s (~) 0.900s 10 1.00x
💻 Local Express 0.169s (-2.8%) 1.002s (~) 0.011s (-1.7%) 1.016s (~) 0.847s 10 1.49x
🐘 Postgres Nitro 1.228s (-49.7% 🟢) 1.814s (-30.2% 🟢) 0.002s (+23.1% 🔺) 2.015s (-33.2% 🟢) 0.787s 10 10.78x
🐘 Postgres Express 2.441s (+179.3% 🔺) 2.602s (+282.7% 🔺) 0.001s (-36.8% 🟢) 3.016s (+198.3% 🔺) 0.575s 10 21.43x
💻 Local Next.js (Turbopack) ⚠️ missing - - - - -
🐘 Postgres Next.js (Turbopack) ⚠️ missing - - - - -

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 1.899s (-3.1%) 2.697s (~) 0.285s (-33.0% 🟢) 3.578s (-2.8%) 1.679s 10 1.00x
▲ Vercel Nitro 1.942s (+3.0%) 2.678s (+9.1% 🔺) 0.238s (-11.6% 🟢) 3.508s (+9.6% 🔺) 1.566s 10 1.02x
▲ Vercel Next.js (Turbopack) 2.437s (+25.6% 🔺) 3.169s (+19.0% 🔺) 0.206s (-9.5% 🟢) 4.069s (+18.2% 🔺) 1.632s 10 1.28x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Nitro 12/12
🐘 Postgres Express 6/12
▲ Vercel Express 5/12
Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 💻 Local 11/12
Next.js (Turbopack) ▲ Vercel 12/12
Nitro 💻 Local 11/12
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a clarifying inline comment in the setupWorkflowContext test helper to explain why referencing ctx.onWorkflowError inside the EventsConsumer callback is safe (the callback closes over ctx, and onWorkflowError is assigned on the same object).

Changes:

  • Document closure behavior for ctx.onWorkflowError usage within onUnconsumedEvent in sleep.test.ts

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Per TooTallNate's review on #1055: the setupWorkflowContext helper
has a circular reference where ctx.onWorkflowError is accessed via
closure before it's defined on the object. Add a clarifying comment.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@pranaygp
Copy link
Copy Markdown
Contributor Author

just a comment add so am merging

pranaygp added a commit that referenced this pull request Feb 16, 2026
* origin/main:
  add closure comment in sleep test helper (#1071)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants