test(core): add closure comment in sleep test helper#1071
Conversation
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)nextjs-turbopack (1 failed):
🌍 Community Worlds (43 failed)turso (43 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
There was a problem hiding this comment.
Pull request overview
Adds a clarifying inline comment in the setupWorkflowContext test helper to explain why referencing ctx.onWorkflowError inside the EventsConsumer callback is safe (the callback closes over ctx, and onWorkflowError is assigned on the same object).
Changes:
- Document closure behavior for
ctx.onWorkflowErrorusage withinonUnconsumedEventinsleep.test.ts
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Per TooTallNate's review on #1055: the setupWorkflowContext helper has a circular reference where ctx.onWorkflowError is accessed via closure before it's defined on the object. Add a clarifying comment. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
0d73e67 to
6946291
Compare
|
just a comment add so am merging |
* origin/main: add closure comment in sleep test helper (#1071)
Summary
sleep.test.ts'ssetupWorkflowContextabout thectx.onWorkflowErrorclosure reference (per TooTallNate's review feedback on fix(core): detect and fatal error on orphaned/invalid events #1055)Test plan
🤖 Generated with Claude Code