Pass teamId to the run-key endpoint#1183
Conversation
🦋 Changeset detectedLatest commit: ab88de4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 15 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (45 failed)turso (45 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
teamId to the run-key endpoint
There was a problem hiding this comment.
Pull request overview
This PR enables team-scoped API requests for workflow run encryption keys by threading the teamId parameter from the configuration through to the Vercel API endpoint. This change ensures that team-specific projects can properly authenticate and retrieve encryption keys for workflow runs.
Changes:
- Thread
teamIdfromconfig.projectConfig.teamIdthroughcreateGetEncryptionKeyForRun()tofetchRunKey() - Add
teamIdas a query parameter in the run-key API request when provided
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/world-vercel/src/index.ts | Passes config?.projectConfig?.teamId to the encryption key factory function |
| packages/world-vercel/src/encryption.ts | Adds teamId parameter to factory function and fetchRunKey(), includes it as a URL query parameter when present |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| if (options?.teamId) { | ||
| params.set('teamId', options.teamId); | ||
| } |
There was a problem hiding this comment.
Consider adding a test case to verify that the teamId query parameter is correctly included in the API request when options.teamId is provided. This would ensure the teamId is properly appended to the URL as expected by the Vercel API.
Summary
teamIdparameter tofetchRunKey()so team-scoped API requests include theteamIdquery parameter when fetching run encryption keysteamIdthroughcreateGetEncryptionKeyForRun()fromconfig.projectConfig.teamIdto the Vercel API call