Lint after biome update (whitespace changes only)#1243
Conversation
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
|
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Express | Nitro Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests▲ Vercel Production (1 failed)example (1 failed):
🌍 Community Worlds (47 failed)turso (47 failed):
Details by Category❌ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
❌ Some E2E test jobs failed:
Check the workflow run for details. |
karthikscale3
left a comment
There was a problem hiding this comment.
Looks good to me. Ran a pass with claude.
Summary
PR #1243 introduces formatting-only updates across 5 files after a Biome upgrade:
docs/scripts/check-docs-smoke.mjs- Reflowed a long arrow function expression into multiple lines.
packages/core/e2e/manifest.test.ts- Large reformat of test blocks (
describe.each,test, assertions) for wrapping/indentation consistency.
- Large reformat of test blocks (
packages/core/src/define-hook.ts- Condensed a multiline conditional type alias into a single-line equivalent form.
packages/core/src/workflow.test.ts- Re-indented and wrapped a long
it.fails(...)test case and related object literals/calls.
- Re-indented and wrapped a long
packages/world-postgres/src/queue.ts- Wrapped a long
pipe.write(...)call across lines.
- Wrapped a long
Overall Assessment
- Net effect: lint/format consistency only; no logic changes detected.
- Regression risk: very low / negligible based on diff review.
- Recommendation: safe to merge, with standard CI checks as routine validation.
#1217 updated biome without reformatting. This PR enforces formatting. No changesets because there are no actual code changes.