Skip to content

[builders] Fix Node.js builtin imports being relativized in step bundles#1644

Merged
VaguelySerious merged 2 commits into
mainfrom
fix/builtin-modules-relativized
Apr 7, 2026
Merged

[builders] Fix Node.js builtin imports being relativized in step bundles#1644
VaguelySerious merged 2 commits into
mainfrom
fix/builtin-modules-relativized

Conversation

@TooTallNate
Copy link
Copy Markdown
Member

@TooTallNate TooTallNate commented Apr 7, 2026

Summary

  • Fixes a regression from fix(builders): resolve path aliases when externalizing non-step imports #1613 where Node.js builtin modules (crypto, node:path, etc.) were incorrectly treated as project-local files by the esbuild fallback resolver, causing them to be rewritten to broken relative paths like ../../../../../../crypto
  • Adds !esbuildResult.external check so modules that esbuild already considers external (builtins) are not relativized
  • Adds a test covering both crypto and node:path style builtin imports

Bug

The esbuild fallback resolver added in 3308701 for path alias support did not check esbuildResult.external. When a builtin like crypto is encountered:

  1. enhancedResolve fails (builtins aren't in node_modules)
  2. build.resolve() succeeds — esbuild resolves builtins as external
  3. The isProjectLocalFile check passed because the path doesn't contain /node_modules/
  4. shouldMakeRelative = true, and relative(outdir, 'crypto') produces ../../../../../../crypto
  5. Downstream webpack build fails: Module not found: Can't resolve '../../../../../../crypto'

@TooTallNate
Fix Node.js builtin imports being relativized in step bundles
cbcc344 
The esbuild fallback resolver introduced in 3308701 did not check
esbuildResult.external, causing builtins like 'crypto' and 'node:path'
to be treated as project-local files and rewritten to broken relative
paths (e.g. '../../../../../../crypto'), failing downstream webpack
builds.
@TooTallNate
Add changeset
87f9a4c
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 7, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
example-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-astro-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-express-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-fastify-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-hono-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-nitro-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-nuxt-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-sveltekit-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workbench-vite-workflow Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm
workflow-swc-playground Ready Ready Preview, Comment, Open in v0 Apr 7, 2026 8:26pm

Copilot AI review requested due to automatic review settings April 7, 2026 20:24
@TooTallNate TooTallNate requested a review from a team as a code owner April 7, 2026 20:24
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 7, 2026

🦋 Changeset detected

Latest commit: 87f9a4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/builders Patch
@workflow/astro Patch
@workflow/cli Patch
@workflow/nest Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/vitest Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch
@workflow/core Patch
@workflow/web-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026 •
edited
Loading

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Express 0.043s (+1.9%) 1.005s (~) 0.962s 10 1.00x
💻 Local Nitro 0.044s (-0.7%) 1.006s (~) 0.962s 10 1.03x
🐘 Postgres Express 0.048s (-12.7% 🟢) 1.009s (~) 0.961s 10 1.13x
🐘 Postgres Next.js (Turbopack) 0.056s 1.009s 0.954s 10 1.29x
🐘 Postgres Nitro 0.058s (-4.9%) 1.011s (~) 0.952s 10 1.36x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 0.222s (-12.1% 🟢) 2.200s (-15.5% 🟢) 1.978s 10 1.00x
▲ Vercel Next.js (Turbopack) 0.268s (-37.0% 🟢) 2.061s (-17.3% 🟢) 1.793s 10 1.21x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 1.115s (-2.7%) 2.010s (~) 0.895s 10 1.00x
💻 Local Express 1.126s (~) 2.005s (~) 0.879s 10 1.01x
💻 Local Nitro 1.128s (~) 2.006s (~) 0.878s 10 1.01x
🐘 Postgres Next.js (Turbopack) 1.145s 2.010s 0.865s 10 1.03x
🐘 Postgres Nitro 1.160s (+0.9%) 2.011s (~) 0.851s 10 1.04x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 1.857s (-3.1%) 3.498s (-6.5% 🟢) 1.641s 10 1.00x
▲ Vercel Next.js (Turbopack) 2.057s (-1.8%) 3.551s (-5.4% 🟢) 1.494s 10 1.11x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 10 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 10.691s (-2.3%) 11.024s (~) 0.333s 3 1.00x
🐘 Postgres Next.js (Turbopack) 10.852s 11.017s 0.165s 3 1.02x
🐘 Postgres Nitro 10.906s (~) 11.025s (~) 0.119s 3 1.02x
💻 Local Express 10.915s (~) 11.022s (~) 0.107s 3 1.02x
💻 Local Nitro 10.931s (-0.8%) 11.023s (-3.0%) 0.093s 3 1.02x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 17.145s (+0.9%) 19.187s (+1.2%) 2.042s 2 1.00x
▲ Vercel Next.js (Turbopack) 17.794s (+4.0%) 18.961s (+0.5%) 1.167s 2 1.04x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 25 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 14.003s (-4.2%) 14.225s (-5.3% 🟢) 0.221s 5 1.00x
🐘 Postgres Nitro 14.631s (~) 15.023s (~) 0.392s 4 1.04x
🐘 Postgres Next.js (Turbopack) 14.641s 15.020s 0.379s 4 1.05x
💻 Local Express 14.933s (~) 15.029s (~) 0.096s 4 1.07x
💻 Local Nitro 14.979s (-0.6%) 15.029s (-4.8%) 0.049s 4 1.07x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 31.699s (+2.4%) 33.644s (+2.5%) 1.945s 2 1.00x
▲ Vercel Next.js (Turbopack) 32.854s (+2.4%) 33.764s (~) 0.910s 2 1.04x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 50 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 13.001s (-7.7% 🟢) 13.451s (-9.6% 🟢) 0.450s 7 1.00x
🐘 Postgres Next.js (Turbopack) 14.024s 14.596s 0.572s 7 1.08x
🐘 Postgres Nitro 14.219s (+0.7%) 15.021s (+1.9%) 0.803s 6 1.09x
💻 Local Nitro 16.626s (-2.1%) 17.030s (-1.9%) 0.404s 6 1.28x
💻 Local Express 16.650s (+1.3%) 17.031s (~) 0.381s 6 1.28x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 56.791s (+4.6%) 58.718s (+5.0%) 1.928s 2 1.00x
▲ Vercel Next.js (Turbopack) 57.312s (-1.3%) 58.687s (-2.8%) 1.375s 2 1.01x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

Promise.all with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 1.198s (-5.2% 🟢) 2.011s (~) 0.812s 15 1.00x
🐘 Postgres Next.js (Turbopack) 1.228s 2.009s 0.781s 15 1.03x
🐘 Postgres Nitro 1.260s (-1.4%) 2.010s (~) 0.749s 15 1.05x
💻 Local Express 1.507s (-3.3%) 2.005s (-3.3%) 0.498s 15 1.26x
💻 Local Nitro 1.508s (-2.9%) 2.006s (~) 0.498s 15 1.26x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.547s (+7.9% 🔺) 4.188s (-4.6%) 1.641s 8 1.00x
▲ Vercel Next.js (Turbopack) 3.440s (+42.6% 🔺) 5.014s (+20.1% 🔺) 1.574s 6 1.35x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

Promise.all with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 2.280s (-2.2%) 3.009s (~) 0.728s 10 1.00x
🐘 Postgres Nitro 2.336s (-0.5%) 3.010s (~) 0.674s 10 1.02x
🐘 Postgres Next.js (Turbopack) 2.406s 3.010s 0.604s 10 1.05x
💻 Local Nitro 2.872s (-9.0% 🟢) 3.108s (-22.5% 🟢) 0.236s 10 1.26x
💻 Local Express 3.050s (+7.6% 🔺) 3.564s (+14.7% 🔺) 0.514s 9 1.34x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.466s (-9.2% 🟢) 3.905s (-15.6% 🟢) 1.438s 8 1.00x
▲ Vercel Next.js (Turbopack) 2.722s (-1.7%) 3.993s (-18.8% 🟢) 1.271s 8 1.10x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

Promise.all with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 3.396s (-2.0%) 4.009s (~) 0.612s 8 1.00x
🐘 Postgres Nitro 3.468s (~) 4.012s (~) 0.544s 8 1.02x
🐘 Postgres Next.js (Turbopack) 3.658s 4.013s 0.355s 8 1.08x
💻 Local Express 8.124s (~) 8.521s (~) 0.397s 4 2.39x
💻 Local Nitro 8.374s (-6.4% 🟢) 9.025s (-2.7%) 0.650s 4 2.47x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 4.474s (+14.2% 🔺) 6.150s (+4.9%) 1.676s 5 1.00x
▲ Vercel Express 4.843s (+48.6% 🔺) 6.555s (+27.9% 🔺) 1.712s 5 1.08x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Next.js (Turbopack) | Express

Promise.race with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 1.196s (-4.3%) 2.009s (~) 0.813s 15 1.00x
🐘 Postgres Next.js (Turbopack) 1.222s 2.009s 0.787s 15 1.02x
🐘 Postgres Nitro 1.246s (~) 2.007s (~) 0.761s 15 1.04x
💻 Local Nitro 1.527s (-2.6%) 2.006s (~) 0.479s 15 1.28x
💻 Local Express 1.534s (+1.8%) 2.006s (~) 0.472s 15 1.28x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 1.982s (-1.0%) 3.190s (-13.1% 🟢) 1.208s 10 1.00x
▲ Vercel Express 2.224s (+4.7%) 4.071s (+4.6%) 1.847s 8 1.12x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Next.js (Turbopack) | Express

Promise.race with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 2.276s (-1.8%) 3.009s (~) 0.733s 10 1.00x
🐘 Postgres Nitro 2.345s (~) 3.009s (~) 0.663s 10 1.03x
🐘 Postgres Next.js (Turbopack) 2.391s 3.009s 0.618s 10 1.05x
💻 Local Nitro 3.017s (-4.1%) 3.566s (-11.1% 🟢) 0.549s 9 1.33x
💻 Local Express 3.073s (-12.9% 🟢) 4.010s (-6.7% 🟢) 0.937s 8 1.35x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.370s (-6.3% 🟢) 3.973s (-13.9% 🟢) 1.602s 8 1.00x
▲ Vercel Next.js (Turbopack) 2.625s (-9.8% 🟢) 4.125s (-20.3% 🟢) 1.500s 8 1.11x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

Promise.race with 50 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 3.406s (-1.4%) 4.011s (~) 0.605s 8 1.00x
🐘 Postgres Nitro 3.493s (+1.0%) 4.012s (~) 0.519s 8 1.03x
🐘 Postgres Next.js (Turbopack) 3.689s 4.012s 0.323s 8 1.08x
💻 Local Nitro 8.678s (-6.7% 🟢) 9.020s (-10.0% 🟢) 0.342s 4 2.55x
💻 Local Express 8.791s (~) 9.024s (-2.7%) 0.233s 4 2.58x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.921s (+1.4%) 4.449s (-4.0%) 1.529s 7 1.00x
▲ Vercel Next.js (Turbopack) 4.015s (+10.9% 🔺) 5.225s (-5.9% 🟢) 1.211s 6 1.37x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 10 sequential data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.608s (-31.8% 🟢) 1.006s (-5.0%) 0.398s 60 1.00x
🐘 Postgres Next.js (Turbopack) 0.793s 1.023s 0.230s 59 1.30x
🐘 Postgres Nitro 0.842s (~) 1.006s (~) 0.165s 60 1.38x
💻 Local Express 0.982s (+0.8%) 1.115s (~) 0.134s 54 1.61x
💻 Local Nitro 0.987s (-2.8%) 1.136s (-36.9% 🟢) 0.150s 53 1.62x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 9.751s (-9.9% 🟢) 10.949s (-13.3% 🟢) 1.198s 6 1.00x
▲ Vercel Express 9.798s (+7.7% 🔺) 11.366s (+2.4%) 1.568s 6 1.00x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Next.js (Turbopack) | Express

workflow with 25 sequential data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 1.524s (-22.8% 🟢) 2.029s (-12.4% 🟢) 0.505s 45 1.00x
🐘 Postgres Next.js (Turbopack) 1.957s 2.227s 0.270s 41 1.28x
🐘 Postgres Nitro 2.082s (+2.6%) 2.884s (+2.2%) 0.802s 32 1.37x
💻 Local Nitro 3.013s (-2.4%) 3.547s (-11.6% 🟢) 0.534s 26 1.98x
💻 Local Express 3.013s (+1.3%) 3.453s (+6.0% 🔺) 0.440s 27 1.98x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 28.760s (~) 30.474s (~) 1.714s 3 1.00x
▲ Vercel Next.js (Turbopack) 29.572s (-0.8%) 30.938s (-1.9%) 1.366s 3 1.03x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 50 sequential data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 3.062s (-24.9% 🟢) 3.676s (-21.2% 🟢) 0.614s 33 1.00x
🐘 Postgres Next.js (Turbopack) 3.825s 4.009s 0.185s 30 1.25x
🐘 Postgres Nitro 4.072s (-2.5%) 4.742s (-5.4% 🟢) 0.670s 26 1.33x
💻 Local Nitro 9.206s (-2.4%) 9.941s (-0.8%) 0.735s 13 3.01x
💻 Local Express 9.254s (+2.1%) 9.941s (+4.0%) 0.687s 13 3.02x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 73.709s (-10.0% 🟢) 75.130s (-10.8% 🟢) 1.421s 2 1.00x
▲ Vercel Express 75.477s (+0.7%) 77.719s (+1.4%) 2.242s 2 1.02x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Next.js (Turbopack) | Express

workflow with 10 concurrent data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.228s (-17.8% 🟢) 1.007s (~) 0.779s 60 1.00x
🐘 Postgres Next.js (Turbopack) 0.253s 1.007s 0.754s 60 1.11x
🐘 Postgres Nitro 0.279s (-2.4%) 1.007s (~) 0.728s 60 1.22x
💻 Local Nitro 0.596s (-4.3%) 1.004s (-1.7%) 0.409s 60 2.61x
💻 Local Express 0.610s (+2.3%) 1.021s (+1.7%) 0.412s 59 2.67x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 1.677s (-14.7% 🟢) 3.082s (-17.1% 🟢) 1.405s 20 1.00x
▲ Vercel Express 2.063s (+5.3% 🔺) 3.529s (-18.8% 🟢) 1.467s 19 1.23x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Next.js (Turbopack) | Express

workflow with 25 concurrent data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.358s (-26.3% 🟢) 1.006s (~) 0.648s 90 1.00x
🐘 Postgres Next.js (Turbopack) 0.482s 1.006s 0.525s 90 1.34x
🐘 Postgres Nitro 0.506s (~) 1.018s (+1.1%) 0.512s 89 1.41x
💻 Local Express 2.474s (-0.8%) 3.009s (~) 0.535s 30 6.90x
💻 Local Nitro 2.528s (-2.5%) 3.009s (~) 0.481s 30 7.05x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.580s (-7.5% 🟢) 4.208s (-11.1% 🟢) 1.628s 22 1.00x
▲ Vercel Next.js (Turbopack) 3.198s (-10.7% 🟢) 4.515s (-14.4% 🟢) 1.317s 20 1.24x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

workflow with 50 concurrent data payload steps (10KB)

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.581s (-27.6% 🟢) 1.006s (~) 0.425s 120 1.00x
🐘 Postgres Next.js (Turbopack) 0.758s 1.006s 0.248s 120 1.30x
🐘 Postgres Nitro 0.803s (~) 1.008s (-0.8%) 0.206s 120 1.38x
💻 Local Express 10.968s (-0.6%) 11.667s (+1.6%) 0.699s 11 18.87x
💻 Local Nitro 11.272s (-2.4%) 11.939s (-0.8%) 0.666s 11 19.39x
💻 Local Next.js (Turbopack) ⚠️ missing - - - -

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 5.911s (-1.9%) 7.592s (-2.0%) 1.681s 16 1.00x
▲ Vercel Next.js (Turbopack) 6.710s (-2.0%) 8.091s (-3.8%) 1.380s 15 1.14x
▲ Vercel Nitro ⚠️ missing - - - -

🔍 Observability: Express | Next.js (Turbopack)

Stream Benchmarks (includes TTFB metrics)
workflow with stream

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.157s (-22.5% 🟢) 0.998s (~) 0.001s (~) 1.009s (~) 0.852s 10 1.00x
🐘 Postgres Next.js (Turbopack) 0.200s 1.000s 0.001s 1.010s 0.810s 10 1.27x
💻 Local Express 0.202s (+0.5%) 1.004s (~) 0.011s (-3.4%) 1.018s (~) 0.816s 10 1.28x
💻 Local Nitro 0.203s (-5.1% 🟢) 1.004s (~) 0.011s (-11.6% 🟢) 1.018s (~) 0.814s 10 1.29x
🐘 Postgres Nitro 0.214s (+6.3% 🔺) 0.995s (~) 0.001s (-17.6% 🟢) 1.009s (~) 0.795s 10 1.36x
💻 Local Next.js (Turbopack) ⚠️ missing - - - - -

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 1.602s (-37.2% 🟢) 3.234s (-20.7% 🟢) 0.191s (-25.5% 🟢) 3.833s (-19.8% 🟢) 2.231s 10 1.00x
▲ Vercel Next.js (Turbopack) 2.032s (-37.3% 🟢) 3.312s (-32.0% 🟢) 0.408s (+7.3% 🔺) 4.095s (-27.7% 🟢) 2.063s 10 1.27x
▲ Vercel Nitro ⚠️ missing - - - - -

🔍 Observability: Express | Next.js (Turbopack)

stream pipeline with 5 transform steps (1MB)

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 0.516s (-21.0% 🟢) 1.006s (~) 0.004s (-33.5% 🟢) 1.021s (~) 0.505s 59 1.00x
🐘 Postgres Nitro 0.616s (~) 1.003s (~) 0.005s (+12.2% 🔺) 1.022s (~) 0.406s 59 1.19x
🐘 Postgres Next.js (Turbopack) 0.639s 1.024s 0.004s 1.037s 0.398s 58 1.24x
💻 Local Nitro 0.746s (-2.5%) 1.013s (~) 0.009s (-15.1% 🟢) 1.023s (~) 0.278s 59 1.45x
💻 Local Express 0.807s (~) 1.012s (~) 0.009s (-10.3% 🟢) 1.115s (~) 0.308s 54 1.56x
💻 Local Next.js (Turbopack) ⚠️ missing - - - - -

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 4.057s (-6.2% 🟢) 5.249s (-12.3% 🟢) 0.233s (-19.5% 🟢) 5.900s (-12.0% 🟢) 1.843s 11 1.00x
▲ Vercel Next.js (Turbopack) 4.707s (+13.8% 🔺) 5.609s (-4.3%) 0.243s (-35.1% 🟢) 6.436s (-4.4%) 1.729s 10 1.16x
▲ Vercel Nitro ⚠️ missing - - - - -

🔍 Observability: Express | Next.js (Turbopack)

10 parallel streams (1MB each)

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Nitro 0.931s (-2.0%) 1.171s (+0.7%) 0.000s (-79.6% 🟢) 1.184s (~) 0.253s 51 1.00x
🐘 Postgres Express 0.949s (~) 1.087s (-10.9% 🟢) 0.000s (+75.0% 🔺) 1.102s (-10.6% 🟢) 0.153s 56 1.02x
🐘 Postgres Next.js (Turbopack) 0.953s 1.229s 0.000s 1.258s 0.305s 48 1.02x
💻 Local Express 1.221s (-13.0% 🟢) 2.020s (~) 0.000s (-18.3% 🟢) 2.022s (-8.1% 🟢) 0.801s 30 1.31x
💻 Local Nitro 1.277s (-2.3%) 2.022s (~) 0.001s (+21.4% 🔺) 2.024s (~) 0.747s 30 1.37x
💻 Local Next.js (Turbopack) ⚠️ missing - - - - -

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.750s (+8.5% 🔺) 4.324s (+11.4% 🔺) 0.000s (+7.7% 🔺) 4.770s (+6.1% 🔺) 2.021s 13 1.00x
▲ Vercel Next.js (Turbopack) 3.176s (-5.3% 🟢) 4.441s (-9.6% 🟢) 0.000s (-100.0% 🟢) 4.774s (-11.0% 🟢) 1.598s 13 1.15x
▲ Vercel Nitro ⚠️ missing - - - - -

🔍 Observability: Express | Next.js (Turbopack)

fan-out fan-in 10 streams (1MB each)

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
🐘 Postgres 🥇 Express 1.715s (-1.6%) 2.104s (~) 0.000s (+50.0% 🔺) 2.127s (+0.6%) 0.412s 29 1.00x
🐘 Postgres Nitro 1.733s (-1.0%) 2.141s (+3.5%) 0.000s (+3.6%) 2.153s (+2.1%) 0.421s 28 1.01x
🐘 Postgres Next.js (Turbopack) 1.841s 2.147s 0.000s 2.153s 0.313s 28 1.07x
💻 Local Express 3.466s (+1.1%) 4.034s (+1.6%) 0.000s (-20.0% 🟢) 4.036s (+1.6%) 0.570s 15 2.02x
💻 Local Nitro 3.676s (-1.4%) 4.169s (+1.7%) 0.001s (+57.1% 🔺) 4.173s (+1.7%) 0.497s 15 2.14x
💻 Local Next.js (Turbopack) ⚠️ missing - - - - -

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.389s (-18.8% 🟢) 4.874s (-12.7% 🟢) 0.000s (NaN%) 5.305s (-12.4% 🟢) 1.916s 12 1.00x
▲ Vercel Next.js (Turbopack) 5.014s (+16.7% 🔺) 6.391s (+10.6% 🔺) 0.001s (+200.0% 🔺) 6.781s (+7.8% 🔺) 1.767s 10 1.48x
▲ Vercel Nitro ⚠️ missing - - - - -

🔍 Observability: Express | Next.js (Turbopack)

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Express 12/21
🐘 Postgres Express 20/21
▲ Vercel Express 16/21
Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 🐘 Postgres 19/21
Next.js (Turbopack) 🐘 Postgres 21/21
Nitro 🐘 Postgres 18/21
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

❌ Some benchmark jobs failed:

  • Local: cancelled
  • Postgres: success
  • Vercel: failure

Check the workflow run for details.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 7, 2026 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
❌ ▲ Vercel Production 877 2 67 946
✅ 💻 Local Development 854 0 178 1032
✅ 📦 Local Production 854 0 178 1032
✅ 🐘 Local Postgres 854 0 178 1032
✅ 🪟 Windows 78 0 8 86
❌ 🌍 Community Worlds 16 60 8 84
✅ 📋 Other 216 0 42 258
Total 3749 62 659 4470

❌ Failed Tests

▲ Vercel Production (2 failed)

vite (2 failed):

  • DurableAgent e2e instructions string instructions are passed to the model
  • hookWorkflow | wrun_01KNMT045RJKF2VRDRXYMBCWTR | 🔍 observability
🌍 Community Worlds (60 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (57 failed):

  • addTenWorkflow | wrun_01KNMSZB7NZB5FQNV4T8KVMYSX
  • addTenWorkflow | wrun_01KNMSZB7NZB5FQNV4T8KVMYSX
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KNMT127MFN3JADHQK3A2RAE4
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KNMSZH3RB3TNPJ1RH74SMD4B
  • promiseRaceWorkflow | wrun_01KNMSZPGRHNMB1A9ECZBJHKDX
  • promiseAnyWorkflow | wrun_01KNMSZREG5RFT2QZ003NJTCGB
  • importedStepOnlyWorkflow | wrun_01KNMT1C3ZWWED488F7T1VTNH1
  • hookWorkflow | wrun_01KNMT045RJKF2VRDRXYMBCWTR
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KNMT1ZFGCMCXNGY1YKQP1QH2
  • webhookWorkflow | wrun_01KNMT28F10Z8W9Y343MK7XPZH
  • sleepingWorkflow | wrun_01KNMT2FWEERY8A10AZCV5RQQF
  • parallelSleepWorkflow | wrun_01KNMT2XGPXQ5MXC0HW21SZ4J8
  • nullByteWorkflow | wrun_01KNMT32FCM0M2HG07TV38WYE2
  • workflowAndStepMetadataWorkflow | wrun_01KNMT34V2YN0EN6G60AHFY9A8
  • fetchWorkflow | wrun_01KNMT5YCARWDNTZQYJKRP3A2H
  • promiseRaceStressTestWorkflow | wrun_01KNMT61WFSXZ5ZFX6616S2VHC
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KNMT9FTE30K9GTG6HMQR4T3V
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KNMTA4HDVPFNCQ5SZG2KG55B
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KNMTAVF794G9QMTVHAV3YM4S
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KNMTBFG9MBSM7JYPN8QK7BN6
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KNMTBR3A5M8GRXRR7MAFGH9C
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KNMTBXGKWM3780YGVXE5G1FY
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KNMTBZNBCJ3JS1Z5ZXVKVN2Q
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KNMTCQK2R8QBRF2GP1D1EF97
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KNMTCXKK4VJBE3Z38SB61D2M
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KNMTD5APWDQXKMFZ5DBFZ7FM
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KNMTDD0B4VDBQNERNZ3DPVX2
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KNMTDKTFMHNB23M1CDSGE8P5
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KNMTDTMFHXA8FQ941W2QFS4V
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KNMTE1CK347CH93T9DFBKVXX
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KNMTEB4SD8JWE9TQQF3E1KPV
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KNMTEKZEQ70SP8EBQB40BWAH
  • cancelRun - cancelling a running workflow | wrun_01KNMTEX255284YS9M99YBP5YV
  • cancelRun via CLI - cancelling a running workflow | wrun_01KNMTF67C4P4QD1BXH8PTGEF9
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KNMTFHYKACYF3BB5BKTB8XYR
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KNMTG8393NB5VJ8GDXKH4NPS
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KNMTGJS520H9EC3SA01N5M1K
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KNMTGS7B6JDHF2Q0THHNK5KP
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KNMTGVCP40BRAYVR40G4M8KN
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KNMTGXFZFBS2J4RQQ3NTE8K4

Details by Category

❌ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 79 0 7
✅ example 79 0 7
✅ express 79 0 7
✅ fastify 79 0 7
✅ hono 79 0 7
✅ nextjs-turbopack 84 0 2
✅ nextjs-webpack 84 0 2
✅ nitro 79 0 7
✅ nuxt 79 0 7
✅ sveltekit 79 0 7
❌ vite 77 2 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 72 0 14
✅ express-stable 72 0 14
✅ fastify-stable 72 0 14
✅ hono-stable 72 0 14
✅ nextjs-turbopack-canary 61 0 25
✅ nextjs-turbopack-stable 78 0 8
✅ nextjs-webpack-canary 61 0 25
✅ nextjs-webpack-stable 78 0 8
✅ nitro-stable 72 0 14
✅ nuxt-stable 72 0 14
✅ sveltekit-stable 72 0 14
✅ vite-stable 72 0 14
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 72 0 14
✅ express-stable 72 0 14
✅ fastify-stable 72 0 14
✅ hono-stable 72 0 14
✅ nextjs-turbopack-canary 61 0 25
✅ nextjs-turbopack-stable 78 0 8
✅ nextjs-webpack-canary 61 0 25
✅ nextjs-webpack-stable 78 0 8
✅ nitro-stable 72 0 14
✅ nuxt-stable 72 0 14
✅ sveltekit-stable 72 0 14
✅ vite-stable 72 0 14
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 72 0 14
✅ express-stable 72 0 14
✅ fastify-stable 72 0 14
✅ hono-stable 72 0 14
✅ nextjs-turbopack-canary 61 0 25
✅ nextjs-turbopack-stable 78 0 8
✅ nextjs-webpack-canary 61 0 25
✅ nextjs-webpack-stable 78 0 8
✅ nitro-stable 72 0 14
✅ nuxt-stable 72 0 14
✅ sveltekit-stable 72 0 14
✅ vite-stable 72 0 14
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 78 0 8
❌ 🌍 Community Worlds
App Passed Failed Skipped
❌ mongodb-dev 4 1 0
❌ redis-dev 4 1 0
❌ turso-dev 4 1 0
❌ turso 4 57 8
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 72 0 14
✅ e2e-local-postgres-nest-stable 72 0 14
✅ e2e-local-prod-nest-stable 72 0 14

📋 View full workflow run

❌ Some E2E test jobs failed:

  • Vercel Prod: failure
  • Local Dev: success
  • Local Prod: success
  • Local Postgres: success
  • Windows: success

Check the workflow run for details.

Copilot AI reviewed Apr 7, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a regression in the @workflow/builders SWC+esbuild plugin where Node.js builtin modules (e.g. crypto, node:path) could be misclassified as project-local paths during the esbuild fallback resolution path, causing them to be rewritten into invalid relative specifiers in step bundles.

Changes:

  • Prevent builtin/external specifiers from being treated as “project-local” during the esbuild fallback resolver by checking !esbuildResult.external.
  • Add a test asserting Node.js builtin imports remain bare specifiers (not relativized) in step bundle output.
  • Add a patch changeset for @workflow/builders.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/builders/src/swc-esbuild-plugin.ts Avoids relativizing esbuild-resolved externals (covers Node.js builtins) when enhanced-resolve fails.
packages/builders/src/swc-esbuild-plugin.test.ts Adds coverage to ensure crypto and node:path stay as bare import specifiers in bundled output.
.changeset/fix-builtin-externalize.md Publishes the fix as a patch release note for @workflow/builders.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TooTallNate TooTallNate enabled auto-merge (squash) April 7, 2026 20:35
@VaguelySerious VaguelySerious disabled auto-merge April 7, 2026 20:35
@VaguelySerious VaguelySerious merged commit 372abba into main Apr 7, 2026
96 of 104 checks passed
@VaguelySerious VaguelySerious deleted the fix/builtin-modules-relativized branch April 7, 2026 20:35
@ghost ghost mentioned this pull request Apr 7, 2026
Merged
VaguelySerious pushed a commit that referenced this pull request Apr 7, 2026
@TooTallNate @VaguelySerious
[builders] Fix Node.js builtin imports being relativized in step bund…
1ef83dc 
…les (#1644)
@TooTallNate TooTallNate mentioned this pull request Apr 10, 2026
Closed
@philcluff philcluff mentioned this pull request Apr 30, 2026
Merged
@TooTallNate TooTallNate mentioned this pull request Apr 30, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@VaguelySerious VaguelySerious VaguelySerious approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate @VaguelySerious