[web-shared]: fix event payload loading (e.g. step_created)#1685
Merged
Conversation
VaguelySerious
approved these changes
Apr 10, 2026
ghost
pushed a commit
that referenced
this pull request
Apr 10, 2026
* Fix event loading issue for step_created event * Update tired-spiders-rhyme.md Signed-off-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com> * add isSystem to attribute panel * remove isSystem * remove hardcoding event data ref fields * fix stale closure --------- Signed-off-by: Karthik Kalyan <105607645+karthikscale3@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR description
What
event-list-view: Reworks when event details load and how they’re merged. Applies cached rows into local state, guards concurrent loads withisLoading, and prefers the fully loaded payload over inline listeventDatawhen both exist. While a fetch is in flight, the UI can keep showing the last known payload instead of blanking out.events-list(sidebar): Uses the same display rule—loadedDataoverridesexistingDataso list snippets don’t block or replace fetched details. Skips duplicate fetches when a payload is already loaded (via a ref-backed guard). On encryption key changes, clears cache and forces a refetch soloadEventDataisn’t stuck behind a staleloadedData !== nullclosure.hasOnlyExpiredFieldsnow usesEVENT_DATA_REF_FIELDSso “all expired” only considers ref/payload keys for thateventType(not a fixed list for every type).hydration(web-shared): Replaces the hardcodedeventDatakey list withEVENT_DATA_REF_FIELDSfor encrypted/expired markers and decrypt paths, only touching keys that exist on the object—aligned with world’s per-event ref fields and avoids touching irrelevant keys.Why
List APIs often return partial or stale
eventData. The old merge order and early returns could prevent or override a full fetch (notably forstep_created). These changes make the timeline and sidebar fetch-first, keep loading UX stable, fix decrypt-after-key reloads, and keep serialization / expiry handling scoped to the fields that actually exist for each event type.