Move swc-playground-wasm into workbench/swc-playground#1704
Merged
Conversation
Move the Rust/WASM source from packages/swc-playground-wasm into workbench/swc-playground/wasm/ so it is no longer built as part of the packages/* turbo filter in CI. The WASM build now runs as part of the playground's own prebuild/dev scripts, avoiding Rust toolchain failures in unrelated CI jobs.
Contributor
|
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (74 failed)mongodb (7 failed):
redis (7 failed):
turso (60 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
workflow with 1 step💻 Local Development
workflow with 10 sequential steps💻 Local Development
workflow with 25 sequential steps💻 Local Development
workflow with 50 sequential steps💻 Local Development
Promise.all with 10 concurrent steps💻 Local Development
Promise.all with 25 concurrent steps💻 Local Development
Promise.all with 50 concurrent steps💻 Local Development
Promise.race with 10 concurrent steps💻 Local Development
Promise.race with 25 concurrent steps💻 Local Development
Promise.race with 50 concurrent steps💻 Local Development
workflow with 10 sequential data payload steps (10KB)💻 Local Development
workflow with 25 sequential data payload steps (10KB)💻 Local Development
workflow with 50 sequential data payload steps (10KB)💻 Local Development
workflow with 10 concurrent data payload steps (10KB)💻 Local Development
workflow with 25 concurrent data payload steps (10KB)💻 Local Development
workflow with 50 concurrent data payload steps (10KB)💻 Local Development
Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
stream pipeline with 5 transform steps (1MB)💻 Local Development
10 parallel streams (1MB each)💻 Local Development
fan-out fan-in 10 streams (1MB each)💻 Local Development
SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
❌ Some benchmark jobs failed:
Check the workflow run for details. |
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the SWC playground WASM crate from a standalone workspace package (packages/swc-playground-wasm) into workbench/swc-playground/wasm, and updates the playground build/dev flow to build + copy the local WASM artifacts.
Changes:
- Relocated the Rust/WASM crate into
workbench/swc-playground/wasmand updated Cargo workspace membership/path dependencies. - Updated the playground to build WASM via local scripts (
build:wasm,prebuild,dev) and copy artifacts fromwasm/pkg/. - Removed the old pnpm workspace package wiring (lockfile importer + changeset pre.json entry + deleted package files).
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| workbench/swc-playground/wasm/src/lib.rs | New WASM entrypoints (transform, transformAll) that run the SWC workflow transform in-browser. |
| workbench/swc-playground/wasm/Cargo.toml | Updated crate location + path dependency to the SWC transform crate. |
| workbench/swc-playground/wasm/build.js | Builds the WASM package via wasm-pack from within the playground workbench. |
| workbench/swc-playground/scripts/copy-wasm.js | Copies build outputs from the new local wasm/pkg/ location into public/wasm/. |
| workbench/swc-playground/package.json | Adds build:wasm and invokes WASM build during prebuild/dev; removes old workspace dep. |
| workbench/swc-playground/.gitignore | Ignores local WASM build artifacts under wasm/pkg/. |
| Cargo.toml | Updates Cargo workspace members to include the new crate location. |
| pnpm-lock.yaml | Removes the deleted pnpm importer/dependency entries. |
| .changeset/pre.json | Removes the stale pre-release entry for the deleted package. |
| packages/swc-playground-wasm/* | Deletes the old workspace package files (package.json, turbo.json). |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (1)
workbench/swc-playground/wasm/build.js:92
runCommandonly accepts a singlecommandargument, so the{ cwd: workspaceRoot }object passed here is ignored and the command always runs in the current process CWD. Either updaterunCommandto accept/pass exec options (includingcwd), or remove the unused options argument to avoid misleading future changes (and consider avoiding embeddingpkgDirinto the shell command to better handle paths with spaces).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
The Vercel build environment has rustup installed but no default toolchain configured. Add a check for this and install stable if needed. Also check for VERCEL env var in addition to CI.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
After cargo install wasm-pack, the binary lives in $CARGO_HOME/bin which may not be in PATH on the Vercel build environment. Always add the cargo bin directory to PATH after ensuring the toolchain.
VaguelySerious
approved these changes
Apr 13, 2026
ijjk
pushed a commit
that referenced
this pull request
Apr 15, 2026
* move swc-playground-wasm into workbench/swc-playground Move the Rust/WASM source from packages/swc-playground-wasm into workbench/swc-playground/wasm/ so it is no longer built as part of the packages/* turbo filter in CI. The WASM build now runs as part of the playground's own prebuild/dev scripts, avoiding Rust toolchain failures in unrelated CI jobs. * fix: ensure default rustup toolchain in wasm build The Vercel build environment has rustup installed but no default toolchain configured. Add a check for this and install stable if needed. Also check for VERCEL env var in addition to CI. * fix: ensure cargo bin dir is in PATH on Vercel After cargo install wasm-pack, the binary lives in $CARGO_HOME/bin which may not be in PATH on the Vercel build environment. Always add the cargo bin directory to PATH after ensuring the toolchain.
TooTallNate
added
the
backport-stable
ghost
pushed a commit
that referenced
this pull request
Apr 16, 2026
* move swc-playground-wasm into workbench/swc-playground Move the Rust/WASM source from packages/swc-playground-wasm into workbench/swc-playground/wasm/ so it is no longer built as part of the packages/* turbo filter in CI. The WASM build now runs as part of the playground's own prebuild/dev scripts, avoiding Rust toolchain failures in unrelated CI jobs. * fix: ensure default rustup toolchain in wasm build The Vercel build environment has rustup installed but no default toolchain configured. Add a check for this and install stable if needed. Also check for VERCEL env var in addition to CI. * fix: ensure cargo bin dir is in PATH on Vercel After cargo install wasm-pack, the binary lives in $CARGO_HOME/bin which may not be in PATH on the Vercel build environment. Always add the cargo bin directory to PATH after ensuring the toolchain.
|
Cherry-pick to |
ghost
mentioned this pull request
|
Backport to To resolve manually: git fetch origin stable
git checkout stable
git cherry-pick 1fa639724180f1d193b32f8ba2c81432c65d1a70
# Fix conflicts, then:
git cherry-pick --continue
git push origin stable |
TooTallNate
added a commit
that referenced
this pull request
Apr 16, 2026
* move swc-playground-wasm into workbench/swc-playground Move the Rust/WASM source from packages/swc-playground-wasm into workbench/swc-playground/wasm/ so it is no longer built as part of the packages/* turbo filter in CI. The WASM build now runs as part of the playground's own prebuild/dev scripts, avoiding Rust toolchain failures in unrelated CI jobs. * fix: ensure default rustup toolchain in wasm build The Vercel build environment has rustup installed but no default toolchain configured. Add a check for this and install stable if needed. Also check for VERCEL env var in addition to CI. * fix: ensure cargo bin dir is in PATH on Vercel After cargo install wasm-pack, the binary lives in $CARGO_HOME/bin which may not be in PATH on the Vercel build environment. Always add the cargo bin directory to PATH after ensuring the toolchain. Co-authored-by: Nathan Rajlich <n@n8.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
packages/swc-playground-wasm(Rust/WASM source, build script) intoworkbench/swc-playground/wasm/so it is no longer a separate workspace packageprebuild/devscripts instead of being built by CI'sturbo build --filter='./packages/*'What changed
packages/swc-playground-wasm/deleted —Cargo.toml,src/lib.rs,build.jsmoved toworkbench/swc-playground/wasm/Cargo.tomlworkspace member updated to point to new locationworkbench/swc-playground/package.json: removed@workflow/swc-playground-wasmworkspace dep, addedbuild:wasmscript,prebuild/devnow invokewasm/build.jsdirectlyscripts/copy-wasm.jsupdated to read from localwasm/pkg/instead ofpackages/swc-playground-wasm/pkg/.changeset/pre.jsoncleaned up to remove stale package entry