Skip to content

Backport #1740: [core] Re-try runtime replays that exceed deadline up to three times#1758

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-1740
Apr 15, 2026
Merged

Backport #1740: [core] Re-try runtime replays that exceed deadline up to three times#1758
VaguelySerious merged 1 commit into
stablefrom
peter/backport-1740

Conversation

@VaguelySerious
Copy link
Copy Markdown
Member

@VaguelySerious VaguelySerious commented Apr 15, 2026

Summary

Backport of #1740 to stable.

When runtime replays exceed the 240s deadline, re-try them up to three times instead of failing immediately. On early attempts the timeout handler exits without writing run_failed, so the queue retries the message. After exhausting retries, the run is marked as failed with an error message indicating the attempt count.

Test plan

  • Unit tests pass (581/581)
  • E2E tests pass locally against nextjs-turbopack dev server (61/61)

@VaguelySerious VaguelySerious requested a review from a team as a code owner April 15, 2026 22:31
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 15, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: 1ee0d59

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/vitest Patch
@workflow/web-shared Patch
@workflow/web Patch
workflow Patch
@workflow/world-testing Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch
@workflow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 15, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Apr 15, 2026 10:34pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Apr 15, 2026 10:34pm
example-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-astro-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-express-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-fastify-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-hono-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-nitro-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-nuxt-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workbench-vite-workflow Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workflow-docs Ready Ready Preview, Comment, Open in v0 Apr 15, 2026 10:34pm
workflow-swc-playground Ready Ready Preview, Comment Apr 15, 2026 10:34pm
workflow-web Ready Ready Preview, Comment Apr 15, 2026 10:34pm

@VaguelySerious VaguelySerious mentioned this pull request Apr 15, 2026
Closed
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 901 0 67 968
✅ 💻 Local Development 874 0 182 1056
✅ 📦 Local Production 874 0 182 1056
✅ 🐘 Local Postgres 874 0 182 1056
✅ 🪟 Windows 80 0 8 88
❌ 🌍 Community Worlds 16 60 8 84
✅ 📋 Other 222 0 42 264
Total 3841 60 671 4572

❌ Failed Tests

🌍 Community Worlds (60 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (57 failed):

  • addTenWorkflow | wrun_01KP9MR6BNHGYNB5CJJZQGS48J
  • addTenWorkflow | wrun_01KP9MR6BNHGYNB5CJJZQGS48J
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KP9MRFQ3PR100V0Z9FQ8PYD9
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KP9MRCZ6HPFBXX1SQ7K06Q21
  • promiseRaceWorkflow | wrun_01KP9MRH8F1NXZKGQ8V24TSMYW
  • promiseAnyWorkflow | wrun_01KP9MRK96HZ5V80H2FMWW0H7M
  • importedStepOnlyWorkflow | wrun_01KP9MRTQX69GGT4JRDFV9E6SX
  • hookWorkflow | wrun_01KP9MRYXEJ2W4T1PB078YS9PG
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KP9MS9RC5KK8GF4AFD0MD53C
  • webhookWorkflow | wrun_01KP9MSJG5ZX0N7RSMR3MG9NHC
  • sleepingWorkflow | wrun_01KP9MSRJP7R4NQ0PJP6HDS6X4
  • parallelSleepWorkflow | wrun_01KP9MT566X22NBVPS91WDRBPR
  • nullByteWorkflow | wrun_01KP9MT8AGX9CS8P7TVYWP8K1K
  • workflowAndStepMetadataWorkflow | wrun_01KP9MTAH0NSJMXPZMC8R2P9VH
  • fetchWorkflow | wrun_01KP9MX0H82WW4GNEJH1Z62JDD
  • promiseRaceStressTestWorkflow | wrun_01KP9MX3SC6STTB6ZRJX9BSPTZ
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KP9N0GJ4P2HJ085WFM029E8Q
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KP9N14MWS7P9XC8RZ2VS71QX
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KP9N1SECBM3ATCZN07EW2E5H
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KP9N2D98A3CV31TS1SMSR6K8
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KP9N2PC52CE7PY9KV6H5TDP1
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KP9N2VJ968W6YR3VZCGAPKN5
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KP9N2XGH9XGXTXT3EYQ3BA4K
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KP9N3CP05314PN501X07JRCM
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KP9N3J1PDW6J4M8ECXHWDMNQ
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KP9N3RQTKN7H3G5HK9XJCRY1
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KP9N3ZERPCGFG6ZTSJSJJSMX
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KP9N45S5SV0FPWD993Q3YKNG
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KP9N4CBG0K84H09W150JB57V
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KP9N4JQJFY5JNNBTA8RHJS7J
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KP9N4XFPR2FJVR2J8H97XG70
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KP9N557C9FH6T969RKKVB596
  • cancelRun - cancelling a running workflow | wrun_01KP9N5BN4287GWAV0FTV09XJG
  • cancelRun via CLI - cancelling a running workflow | wrun_01KP9N5NAF7ZMCJMXX3MKFBHNT
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KP9N6143CHBKPKGKQ5QP0B31
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KP9N6N5Q886QQHM56CZFG0TH
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KP9N70F1WD56RQQ0DDTKF7WN
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KP9N76W43AV6G3YCR97MFDSW
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KP9N7921ZABBGM0Y7SWMGMME
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KP9N7B280A1W3R3BP2R8MPC2

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 81 0 7
✅ example 81 0 7
✅ express 81 0 7
✅ fastify 81 0 7
✅ hono 81 0 7
✅ nextjs-turbopack 86 0 2
✅ nextjs-webpack 86 0 2
✅ nitro 81 0 7
✅ nuxt 81 0 7
✅ sveltekit 81 0 7
✅ vite 81 0 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 74 0 14
✅ express-stable 74 0 14
✅ fastify-stable 74 0 14
✅ hono-stable 74 0 14
✅ nextjs-turbopack-canary 61 0 27
✅ nextjs-turbopack-stable 80 0 8
✅ nextjs-webpack-canary 61 0 27
✅ nextjs-webpack-stable 80 0 8
✅ nitro-stable 74 0 14
✅ nuxt-stable 74 0 14
✅ sveltekit-stable 74 0 14
✅ vite-stable 74 0 14
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 74 0 14
✅ express-stable 74 0 14
✅ fastify-stable 74 0 14
✅ hono-stable 74 0 14
✅ nextjs-turbopack-canary 61 0 27
✅ nextjs-turbopack-stable 80 0 8
✅ nextjs-webpack-canary 61 0 27
✅ nextjs-webpack-stable 80 0 8
✅ nitro-stable 74 0 14
✅ nuxt-stable 74 0 14
✅ sveltekit-stable 74 0 14
✅ vite-stable 74 0 14
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 74 0 14
✅ express-stable 74 0 14
✅ fastify-stable 74 0 14
✅ hono-stable 74 0 14
✅ nextjs-turbopack-canary 61 0 27
✅ nextjs-turbopack-stable 80 0 8
✅ nextjs-webpack-canary 61 0 27
✅ nextjs-webpack-stable 80 0 8
✅ nitro-stable 74 0 14
✅ nuxt-stable 74 0 14
✅ sveltekit-stable 74 0 14
✅ vite-stable 74 0 14
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 80 0 8
❌ 🌍 Community Worlds
App Passed Failed Skipped
❌ mongodb-dev 4 1 0
❌ redis-dev 4 1 0
❌ turso-dev 4 1 0
❌ turso 4 57 8
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 74 0 14
✅ e2e-local-postgres-nest-stable 74 0 14
✅ e2e-local-prod-nest-stable 74 0 14

📋 View full workflow run

@VaguelySerious VaguelySerious merged commit fb3c118 into stable Apr 15, 2026
86 of 89 checks passed
@VaguelySerious VaguelySerious deleted the peter/backport-1740 branch April 15, 2026 23:25
@ghost ghost mentioned this pull request Apr 14, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3 karthikscale3 karthikscale3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious @karthikscale3