Skip to content

[world-local] Backport: enable cross-process streaming tests#1765

Merged
VaguelySerious merged 1 commit into
stablefrom
peter/backport-enable-tests
Apr 16, 2026
Merged

[world-local] Backport: enable cross-process streaming tests#1765
VaguelySerious merged 1 commit into
stablefrom
peter/backport-enable-tests

Conversation

@VaguelySerious
Copy link
Copy Markdown
Member

@VaguelySerious VaguelySerious commented Apr 16, 2026

Summary

  • Backports filesystem polling from PR [world-local] Cross-process streaming for local dev via polling, enable e2e tests #1739 (peter/enable-tests on main) to the stable branch
  • Adds setInterval(100ms) polling to readFromStream() so cross-process streaming works (test runner <> workbench app share a filesystem but not an EventEmitter)
  • Removes skipIf(isLocalDeployment()) from streaming e2e tests so they run locally too
  • Adds a cross-process polling unit test that writes chunk files directly to disk (bypassing EventEmitter) and verifies the polling reader delivers them

Test plan

  • pnpm vitest run packages/world-local/src/streamer.test.ts — 42 tests pass (including new polling test)
  • pnpm vitest run packages/core/src — 581 tests pass
  • CI checks pass

🤖 Generated with Claude Code

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Apr 16, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Apr 16, 2026 2:45am
example-nextjs-workflow-webpack Ready Ready Preview, Comment Apr 16, 2026 2:45am
example-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-astro-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-express-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-fastify-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-hono-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-nitro-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-nuxt-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-sveltekit-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workbench-vite-workflow Ready Ready Preview, Comment Apr 16, 2026 2:45am
workflow-docs Ready Ready Preview, Comment, Open in v0 Apr 16, 2026 2:45am
workflow-swc-playground Ready Ready Preview, Comment Apr 16, 2026 2:45am
workflow-web Ready Ready Preview, Comment Apr 16, 2026 2:45am

@VaguelySerious VaguelySerious requested a review from a team as a code owner April 16, 2026 02:42
@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Apr 16, 2026 •
edited
Loading

🦋 Changeset detected

Latest commit: c649119

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@workflow/world-local Patch
@workflow/cli Patch
@workflow/core Patch
@workflow/vitest Patch
@workflow/world-postgres Patch
workflow Patch
@workflow/world-testing Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
@workflow/web Patch
@workflow/ai Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 16, 2026 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 901 0 67 968
✅ 💻 Local Development 970 0 86 1056
✅ 📦 Local Production 970 0 86 1056
✅ 🐘 Local Postgres 970 0 86 1056
✅ 🪟 Windows 88 0 0 88
❌ 🌍 Community Worlds 16 68 0 84
✅ 📋 Other 246 0 18 264
Total 4161 68 343 4572

❌ Failed Tests

🌍 Community Worlds (68 failed)

mongodb-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

redis-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso-dev (1 failed):

  • dev e2e should rebuild on imported step dependency change

turso (65 failed):

  • addTenWorkflow | wrun_01KPA2TV2MX5RR1HVJJ658GBDE
  • addTenWorkflow | wrun_01KPA2TV2MX5RR1HVJJ658GBDE
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KPA2VVV99PWW56WQYJKE3HTF
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KPA2V2FSTVZQ1AHHBSX8PEWT
  • promiseRaceWorkflow | wrun_01KPA2V7SH8JDY8G2078F8DG0Z
  • promiseAnyWorkflow | wrun_01KPA2VASWXN5XPZ4GAH99BXR9
  • importedStepOnlyWorkflow | wrun_01KPA2W51WMQH0ZJWEK27P837J
  • readableStreamWorkflow | wrun_01KPA2VDDHRCC2JBSY5A6KJQZ5
  • hookWorkflow | wrun_01KPA2VQ40FTX2A21PZEPR4A0A
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KPA2W18FF0FS31AQQSVFJR28
  • webhookWorkflow | wrun_01KPA2WBYDJ5VPK4ZG6HPS0JZT
  • sleepingWorkflow | wrun_01KPA2WHDJV0QHQZW895BYKRT0
  • parallelSleepWorkflow | wrun_01KPA2WXH472PDHBXXPYJS0Z8B
  • nullByteWorkflow | wrun_01KPA2X1VR8CMTKA3RZZAAFS2G
  • workflowAndStepMetadataWorkflow | wrun_01KPA2X3QYGX5GGYD3V0VR6SC2
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KPA2ZA8X3C38T94CV15RQAVZ
  • fetchWorkflow | wrun_01KPA2ZR9HB6NMW3JHCCTKS39F
  • promiseRaceStressTestWorkflow | wrun_01KPA2ZVBG0ZQG7V01KAAXVCR4
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KPA337JP5WSAKQVS6RWR5JR3
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KPA33WXPF0WV5B2PNM89TWJ1
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KPA34GZ9GAY5RPV26XZ2MG97
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KPA35509SV9CVQQ795ATGG5J
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KPA35DC3RG9WE2BN7MVB8HYC
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KPA35KD68H89J0B843BX6N9J
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KPA35NAT6687C1WGQ6T9M4C2
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KPA36450KDJV9AGQAJEDE51R
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KPA3698GJPCVBBCQY26XMTBQ
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KPA36GZZ9VQNGY24RR29BEE9
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KPA36Q8PH7TFJFQGSK9SASN3
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KPA36XM0S9CH601GAARDMEBX
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KPA37434TQBS2SZSTWSGDE2Z
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KPA37AETTJ0T00R5SFKGF6W2
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KPA37QG3WFRW9RFR2R64WZRC
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KPA37YX9720AKMYXCHCXV3F0
  • cancelRun - cancelling a running workflow | wrun_01KPA385F5GPK0WP7TAYK12K97
  • cancelRun via CLI - cancelling a running workflow | wrun_01KPA38EJE19HWQ6BYHZJV7TPT
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KPA38T4809X1P34W8BWBHNQK
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KPA39DW9WS3EKG59EVTGXEKP
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KPA39S35WGAJDNACE3VXGR7M
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KPA39ZH5NB4KNJYAF37904BW
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KPA3A1PDFGF61X5JF1SVN90N
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KPA3A58GY3BMKW9BH30CF6B3

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 81 0 7
✅ example 81 0 7
✅ express 81 0 7
✅ fastify 81 0 7
✅ hono 81 0 7
✅ nextjs-turbopack 86 0 2
✅ nextjs-webpack 86 0 2
✅ nitro 81 0 7
✅ nuxt 81 0 7
✅ sveltekit 81 0 7
✅ vite 81 0 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 88 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
❌ mongodb-dev 4 1 0
❌ redis-dev 4 1 0
❌ turso-dev 4 1 0
❌ turso 4 65 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 82 0 6
✅ e2e-local-postgres-nest-stable 82 0 6
✅ e2e-local-prod-nest-stable 82 0 6

📋 View full workflow run

@VaguelySerious @claude
[world-local] Backport: enable cross-process streaming via filesystem…
c649119 
… polling

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Peter Wielander <mittgfu@gmail.com>
@VaguelySerious VaguelySerious force-pushed the peter/backport-enable-tests branch from 6c1de09 to c649119 Compare April 16, 2026 02:42
@VaguelySerious VaguelySerious enabled auto-merge (squash) April 16, 2026 02:54
@VaguelySerious VaguelySerious disabled auto-merge April 16, 2026 04:36
@VaguelySerious VaguelySerious merged commit 5bc4191 into stable Apr 16, 2026
86 of 89 checks passed
@VaguelySerious VaguelySerious deleted the peter/backport-enable-tests branch April 16, 2026 04:36
@ghost ghost mentioned this pull request Apr 15, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@karthikscale3 karthikscale3 karthikscale3 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@VaguelySerious @karthikscale3