Skip to content

[backport] [vitest] [world-local] Fix local-world data recovery isolation (#1895)#1898

Merged
VaguelySerious merged 2 commits into
stablefrom
peter/backport-1895-stable
May 4, 2026
Merged

[backport] [vitest] [world-local] Fix local-world data recovery isolation (#1895)#1898
VaguelySerious merged 2 commits into
stablefrom
peter/backport-1895-stable

Conversation

@VaguelySerious
Copy link
Copy Markdown
Member

Backports #1895 onto `stable`.

Cherry-pick of `2f52d14f38` with conflict resolution for stable's diverged state:

  • `packages/vitest/package.json`: Kept stable's `vite` version (`7.1.12`) but added the new `vitest` devDep so the new `packages/vitest/src/index.test.ts` can run.
  • `packages/core/e2e/dev.test.ts`: Stable still uses the copied-step-files mechanism (the `step file copy` removal in refactor(next): remove step file copy mechanism from deferred builder #1796 is on main only), so the test bodies were kept verbatim from stable. Adopted the new `apiFile` retry-on-500 try/catch from the cherry-pick where it composes cleanly with the copied-files check. Did not adopt the manifest-based assertion or the in-test teardown (manifest.json is not produced by stable's deferred builder).
  • `pnpm-lock.yaml`: Regenerated via `pnpm install --lockfile-only`.

Verified locally:

  • `pnpm --filter @workflow/vitest test`: 5/5 passing
  • `pnpm --filter @workflow/world-local test`: 270/270 passing

🤖 Generated with Claude Code

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 2, 2026

🦋 Changeset detected

Latest commit: f5eb529

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 19 packages
Name Type
@workflow/vitest Patch
@workflow/world-local Patch
@workflow/cli Patch
@workflow/core Patch
@workflow/world-postgres Patch
workflow Patch
@workflow/world-testing Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
@workflow/web Patch
@workflow/ai Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch
@workflow/nuxt Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 2, 2026

🧪 E2E Test Results

Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 901 0 67 968
✅ 💻 Local Development 970 0 86 1056
✅ 📦 Local Production 970 0 86 1056
✅ 🐘 Local Postgres 970 0 86 1056
✅ 🪟 Windows 88 0 0 88
❌ 🌍 Community Worlds 140 82 0 222
✅ 📋 Other 246 0 18 264
Total 4285 82 343 4710

❌ Failed Tests

🌍 Community Worlds (82 failed)

mongodb (10 failed):

  • readableStreamWorkflow | wrun_01KQNW58D2XG9FGYJRMGFDQN9C
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5ZNDM6T063TY841BRHQ4
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KQNW9FDJQQ1AZG7P6X6BGX87
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE6M40B8ZXTBER0X1FKQP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWN7HDAM6H3D1FXZ455410

redis (7 failed):

  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5ZNDM6T063TY841BRHQ4
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE6M40B8ZXTBER0X1FKQP
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWN7HDAM6H3D1FXZ455410

turso (65 failed):

  • addTenWorkflow | wrun_01KQNW4MM9C1PKBAJ5VEG8Q531
  • addTenWorkflow | wrun_01KQNW4MM9C1PKBAJ5VEG8Q531
  • wellKnownAgentWorkflow (.well-known/agent) | wrun_01KQNW5TE3814RJVRQC6JAHQ1E
  • should work with react rendering in step
  • promiseAllWorkflow | wrun_01KQNW4XS2P65E9KTR1KZ3YK18
  • promiseRaceWorkflow | wrun_01KQNW52HX9TFT0EWG31RD0GKE
  • promiseAnyWorkflow | wrun_01KQNW562VEHM8GDGZA2DNN7CZ
  • importedStepOnlyWorkflow | wrun_01KQNW65KHBZ1Z5SWE2WMC2SE5
  • readableStreamWorkflow | wrun_01KQNW58D2XG9FGYJRMGFDQN9C
  • hookWorkflow | wrun_01KQNW5K4TDKFM56VS2F7JA5BP
  • hookWorkflow is not resumable via public webhook endpoint | wrun_01KQNW5ZNDM6T063TY841BRHQ4
  • webhookWorkflow | wrun_01KQNW693111CJ2VFVVBAACQHE
  • sleepingWorkflow | wrun_01KQNW6G0DM0HVYW1RYKJDCQTM
  • parallelSleepWorkflow | wrun_01KQNW6VYR3DXW3SAQ0VDPC3RH
  • nullByteWorkflow | wrun_01KQNW6ZE787PPW6SNTBQXXEF9
  • workflowAndStepMetadataWorkflow | wrun_01KQNW71NSY59SRM0E6T1NT8JH
  • outputStreamWorkflow no startIndex (reads all chunks)
  • outputStreamWorkflow positive startIndex (skips first chunk)
  • outputStreamWorkflow negative startIndex (reads from end)
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns correct index after stream completes
  • outputStreamWorkflow - getTailIndex and getStreamChunks getTailIndex returns -1 before any chunks are written
  • outputStreamWorkflow - getTailIndex and getStreamChunks getStreamChunks returns same content as reading the stream
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions | wrun_01KQNW9FDJQQ1AZG7P6X6BGX87
  • fetchWorkflow | wrun_01KQNW9V8WXHWNSE91XW8GS3TR
  • promiseRaceStressTestWorkflow | wrun_01KQNW9YVVK5RV9P371ANYWR15
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • error handling not registered WorkflowNotRegisteredError fails the run when workflow does not exist
  • error handling not registered StepNotRegisteredError fails the step but workflow can catch it
  • error handling not registered StepNotRegisteredError fails the run when not caught in workflow
  • hookCleanupTestWorkflow - hook token reuse after workflow completion | wrun_01KQNWDHCGWXTBTBNGH02JJM0K
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously | wrun_01KQNWE6M40B8ZXTBER0X1FKQP
  • hookDisposeTestWorkflow - hook token reuse after explicit disposal while workflow still running | wrun_01KQNWEW5XZWS3EMPWPE9664NK
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars) | wrun_01KQNWFHE79FH7VH7ZTMSVEYCW
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument | wrun_01KQNWFTWW3247JX7KQCWFJ844
  • closureVariableWorkflow - nested step functions with closure variables | wrun_01KQNWG0R3DZGQ7609V31HZSCK
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step | wrun_01KQNWG331XSZ2ZZ49EPZ8A5D3
  • health check (queue-based) - workflow and step endpoints respond to health check messages
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly | wrun_01KQNWGKMYVM3MZV5PEY3RV1J5
  • Calculator.calculate - static workflow method using static step methods from another class | wrun_01KQNWGS15XEEP0XQSCFJWQ010
  • AllInOneService.processNumber - static workflow method using sibling static step methods | wrun_01KQNWH5FGETJ19NXH6MSWHF2J
  • ChainableService.processWithThis - static step methods using this to reference the class | wrun_01KQNWHCKE0PY3Y1S0F3ASG841
  • thisSerializationWorkflow - step function invoked with .call() and .apply() | wrun_01KQNWHKK0SPH9A91FS9PNSY61
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE | wrun_01KQNWHX1AYVAYBEVR6RE28TXK
  • instanceMethodStepWorkflow - instance methods with "use step" directive | wrun_01KQNWJ4164P056FW6HKDG6MQX
  • crossContextSerdeWorkflow - classes defined in step code are deserializable in workflow context | wrun_01KQNWJERXHWJZVSPGEJJ8CEQQ
  • stepFunctionAsStartArgWorkflow - step function reference passed as start() argument | wrun_01KQNWJQ0CEQF9C6GWCCE8T7JM
  • cancelRun - cancelling a running workflow | wrun_01KQNWJZRHAS75270ZVWDZ9YXA
  • cancelRun via CLI - cancelling a running workflow | wrun_01KQNWK9HER6TH25YB46HX2R5R
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router
  • hookWithSleepWorkflow - hook payloads delivered correctly with concurrent sleep | wrun_01KQNWKQ8VK2ZVJ4BG0KJA9GWD
  • sleepInLoopWorkflow - sleep inside loop with steps actually delays each iteration | wrun_01KQNWMGCFJRNAZ899MVQPB554
  • sleepWithSequentialStepsWorkflow - sequential steps work with concurrent sleep (control) | wrun_01KQNWMVFGWQ7HVX2XGHBHKJRD
  • importMetaUrlWorkflow - import.meta.url is available in step bundles | wrun_01KQNWN2Y6MB4GR35SSXKWQZCE
  • metadataFromHelperWorkflow - getWorkflowMetadata/getStepMetadata work from module-level helper (#1577) | wrun_01KQNWN59N4SZH2MZQCASQ2QCH
  • resilient start: addTenWorkflow completes when run_created returns 500 | wrun_01KQNWN7HDAM6H3D1FXZ455410

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 81 0 7
✅ example 81 0 7
✅ express 81 0 7
✅ fastify 81 0 7
✅ hono 81 0 7
✅ nextjs-turbopack 86 0 2
✅ nextjs-webpack 86 0 2
✅ nitro 81 0 7
✅ nuxt 81 0 7
✅ sveltekit 81 0 7
✅ vite 81 0 7
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 82 0 6
✅ express-stable 82 0 6
✅ fastify-stable 82 0 6
✅ hono-stable 82 0 6
✅ nextjs-turbopack-canary 69 0 19
✅ nextjs-turbopack-stable 88 0 0
✅ nextjs-webpack-canary 69 0 19
✅ nextjs-webpack-stable 88 0 0
✅ nitro-stable 82 0 6
✅ nuxt-stable 82 0 6
✅ sveltekit-stable 82 0 6
✅ vite-stable 82 0 6
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 88 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 5 0 0
❌ mongodb 59 10 0
✅ redis-dev 5 0 0
❌ redis 62 7 0
✅ turso-dev 5 0 0
❌ turso 4 65 0
✅ 📋 Other
App Passed Failed Skipped
✅ e2e-local-dev-nest-stable 82 0 6
✅ e2e-local-postgres-nest-stable 82 0 6
✅ e2e-local-prod-nest-stable 82 0 6

📋 View full workflow run

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment May 3, 2026 2:56am
example-nextjs-workflow-webpack Ready Ready Preview, Comment May 3, 2026 2:56am
example-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-astro-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-express-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-fastify-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-hono-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-nitro-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-nuxt-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-sveltekit-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workbench-vite-workflow Ready Ready Preview, Comment May 3, 2026 2:56am
workflow-docs Ready Ready Preview, Comment, Open in v0 May 3, 2026 2:56am
workflow-swc-playground Ready Ready Preview, Comment May 3, 2026 2:56am
workflow-web Ready Ready Preview, Comment May 3, 2026 2:56am

Copy link
Copy Markdown
Member

@TooTallNate TooTallNate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the backport against the original #1895. All conflict resolutions match the PR description's claims:

  • packages/vitest/package.json: Confirmed — vite stays at 7.1.12 (stable's pin), vitest@catalog added to devDeps. Diff is identical to the corresponding section in #1895 except for the preserved vite version.

  • packages/core/e2e/dev.test.ts: Confirmed — stable still uses supportsDeferredStepCopies with the copiedStepDir / __workflow_step_files__ mechanism (verified on stable directly). The backport correctly:

    • Adopts the new afterEach restore-then-delete reorder + Windows comment ✓
    • Adopts the apiFile retry-on-500 try/catch around triggerWorkflowRun
    • Bumps the timeout from 30s → 60s ✓
    • Does NOT adopt the manifest-based assertion or in-test teardown (those depend on main's deferred builder structure, not stable's) ✓
  • All other files are byte-identical to #1895: packages/vitest/src/{global-setup,setup-file,index,options,vitest-context.d}.ts, packages/vitest/src/index.test.ts, packages/world-local/src/{config,fs,index,storage/{index,runs-storage}}.ts, packages/world-local/src/{fs.test,reenqueue.test}.ts, docs/content/docs/api-reference/vitest/index.mdx, both changesets. Confirmed via diff of the per-file hunks.

The substance is the same fix I approved in #1895 (vitest project-context isolation, world-local recovery scoped by tag, dedupe of createStorage calls), now correctly adapted to stable's diverged state.

@VaguelySerious VaguelySerious merged commit e428cdb into stable May 4, 2026
210 of 216 checks passed
@VaguelySerious VaguelySerious deleted the peter/backport-1895-stable branch May 4, 2026 09:38
@github-actions github-actions Bot mentioned this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants