[world] Add various @fantasticfour org worlds to manifest#1964
Conversation
|
|
@vinnymac is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
| "credentialsNote": "Requires JAZZ_API_KEY, JAZZ_WORKER_ACCOUNT, and JAZZ_WORKER_SECRET from Jazz Cloud" | ||
| }, | ||
| { | ||
| "id": "redis-simple", |
There was a problem hiding this comment.
can we actually set this to fantasticfour-redis or similar? just realized we probably need to update the other community worlds too, to be less ambiguous. redis and redis-simple are confusing
There was a problem hiding this comment.
I agree with you, it's a bit confusing at the moment if this was to be merged as-is. I was wondering how we were going to handle this. Figured this was the perfect time to begin a discussion to address it.
I can make that change if you like, and update the others to include the published org or username?
| "setup": "pnpm exec fantasticfour-redis-setup" | ||
| }, | ||
| { | ||
| "id": "redis-bullmq", |
There was a problem hiding this comment.
same here, let's update the id to fantasticfour-redis-bullmq?
| { | ||
| "id": "cloudflare", | ||
| "type": "community", | ||
| "package": "@fantasticfour/world-cloudflare", |
| "requiresDeployment": true | ||
| }, | ||
| { | ||
| "id": "mysql", |
| "setup": "pnpm exec world-mysql-setup" | ||
| }, | ||
| { | ||
| "id": "azure", |
| "credentialsNote": "Requires Azure Cosmos DB endpoint/key and Service Bus connection string" | ||
| }, | ||
| { | ||
| "id": "nats-jetstream", |
| "credentialsNote": "Requires NATS server with JetStream enabled (CI does not yet support nats service containers)" | ||
| }, | ||
| { | ||
| "id": "upstash", |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Register the Fantastic Four community world packages in the worlds manifest and show the Redis variants in the Embedded docs section. Co-authored-by: Vincent Taverna <vinnymac@gmail.com> Signed-off-by: Pranay Prakash <pranay.gp@gmail.com>
|
No backport to This commit modifies To override, re-run the Backport to stable workflow manually via |
|
merged! just fyi I had to squash the commit because of signed commit requirements on the repo |
|
Follow-up from trying to wire the Cloudflare community world into actual workbench e2e coverage: I think this is currently blocked by Workflow runtime itself, not by
So this world can still be useful as the Cloudflare-backed World adapter, but I don't think a workbench deployed directly to Workers can run the real Workflow e2e suite until Workflow has a Worker-compatible runtime path. I opened a central tracker here: #2028 The likely related unblocker is @TooTallNate's QuickJS snapshot runtime PR, which appears to remove the I also opened the source-repo issue here: vinnymac/worlds#30 |
Let me know if you'd prefer if I tweak the changes here, as I have never submitted a community world before. The world implementations all currently target 4.1 Workflows. I've written test coverage for each world, and based the initial implementations for all of them based on
world-postgres.Is it possible for me to configure services in this manifest for other infra, such as mysql or infra emulation?
Summary
Registers seven community @fantasticfour/* world implementations in worlds-manifest.json so they're discoverable alongside the existing first-party and community worlds. Each entry includes its package name, repo/docs links, required env vars, and a credentials note when external infrastructure is needed.
Worlds added
redis-simple@fantasticfour/world-redisredis-bullmq@fantasticfour/world-redis-bullmqcloudflare@fantasticfour/world-cloudflaremysql@fantasticfour/world-mysqlazure@fantasticfour/world-azurenats-jetstream@fantasticfour/world-nats-jetstreamupstash@fantasticfour/world-upstashOther Worlds
I also have some other implementations for firestore Tasks, postgres + redis, mysql + redis, but they are more experimental and less practical.