fix(nitro): respect workflow.dirs option#2002
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
Signed-off-by: EfeDurmaz16 <efebarandurmaz05@gmail.com>
Contributor
|
@EfeDurmaz16 is attempting to deploy a commit to the Vercel Labs Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nitro.options.workflow?.dirsinto both Nitro workflow builders['.']scan default whenworkflow.dirsis unset\n- Add regression coverage forVercelBuilderandLocalBuilder\n- Add a patch changeset for@workflow/nitro\n\nCloses [nitro] workflow.dirs config option is ignored by VercelBuilder and LocalBuilder #1684.\n\n## Verification\n-pnpm --filter @workflow/rollup build\n-pnpm --filter @workflow/builders build\n-pnpm --filter @workflow/vite build\n-pnpm --filter @workflow/nitro exec vitest run src/index.test.ts -t 'workflow.dirs forwarding'\n-pnpm --filter @workflow/nitro build\n-pnpm exec biome check packages/nitro/src/builders.ts packages/nitro/src/index.test.ts .changeset/nitro-workflow-dirs.md\n-git diff --check\n-pnpm changeset status --since=origin/main\n\nNote: local pnpm commands warn because this machine is on Node v26.0.0 while the repo engine allows Node 18/20/22/24. A direct fullvitest run src/index.test.tscurrently fails in two pre-existing virtual-handler assertions unrelated to this builder-config change; the newworkflow.dirs forwardingtests pass.