Use "stepId" instead of Symbol.for("STEP_FUNCTION_NAME_SYMBOL") for annotating step functions#341
Merged
Conversation
🦋 Changeset detectedLatest commit: 2288833 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Member
Author
TooTallNate
requested review from
Schniz,
VaguelySerious,
adriandlam,
ijjk and
pranaygp
ijjk
approved these changes
Nov 14, 2025
This was referenced Nov 14, 2025
VaguelySerious
approved these changes
Nov 14, 2025
| configurable: false, | ||
| } | ||
| ); | ||
| Object.defineProperty(stepFunction, 'stepId', { |
Member
There was a problem hiding this comment.
Curious why this isn't also a symbol, e.g. Symbol.for('WORKFLOW_STEP_FUNCTION_STEP_ID') or similar. I guess it's unlikely people will patch this property onto their functions manually so totally fine
Member
Author
There was a problem hiding this comment.
It's for consistency with how we annotate workflow functions with workflowId. This PR is more of a cosmetic change.
TooTallNate
force-pushed
the
11-13-remove_step_function_identifier_transform_out_of_swc-plugin_and_into_usestep_runtime_function
branch
from
6786aac to
e8fe109
Compare
TooTallNate
force-pushed
the
11-13-use_stepid_instead_of_symbol.for_step_function_name_symbol_for_annotating_step_functions
branch
from
8e9a498 to
75e95ad
Compare
This was referenced Nov 15, 2025
Merged
TooTallNate
changed the base branch from
11-13-remove_step_function_identifier_transform_out_of_swc-plugin_and_into_usestep_runtime_function
to
graphite-base/341
TooTallNate
force-pushed
the
graphite-base/341
branch
from
e8fe109 to
5eb588a
Compare
TooTallNate
force-pushed
the
11-13-use_stepid_instead_of_symbol.for_step_function_name_symbol_for_annotating_step_functions
branch
from
75e95ad to
2c7bbdf
Compare
… annotating step functions
TooTallNate
force-pushed
the
11-13-use_stepid_instead_of_symbol.for_step_function_name_symbol_for_annotating_step_functions
branch
from
2c7bbdf to
2288833
Compare
TooTallNate
deleted the
11-13-use_stepid_instead_of_symbol.for_step_function_name_symbol_for_annotating_step_functions
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace
Symbol.for("WORKFLOW_STEP_FUNCTION_NAME")with a standardstepIdproperty for step function annotation.What changed?
STEP_FUNCTION_NAME_SYMBOL(a Symbol) with a regularstepIdproperty on step functionsstepIdproperty instead of the SymbolSTEP_FUNCTION_NAME_SYMBOLconstant from symbols.tsWhy make this change?
This more closely resembles how Workflow functions are annotated with a
workflowIdproperty.