Skip to content

Remove unused getWritable stub function#855

Merged
pranaygp merged 1 commit into
mainfrom
01-26-remove_unused_getwritable_stub_function
Jan 26, 2026
Merged

Remove unused getWritable stub function#855
pranaygp merged 1 commit into
mainfrom
01-26-remove_unused_getwritable_stub_function

Conversation

@TooTallNate
Copy link
Copy Markdown
Member

@TooTallNate TooTallNate commented Jan 26, 2026 •
edited
Loading

Removed unused getWritable stub function and relocated its interface definition. It was left over from a time where there were separate default vs. "step" context export conditions, which no longer exists.

What changed?

  • Removed the standalone writable-stream.ts file which contained an unused stub implementation of getWritable
  • Moved the WorkflowWritableStreamOptions interface from the deleted file to step/writable-stream.ts
  • Updated imports in workflow/writable-stream.ts to reference the interface from its new location

How to test?

Verify that all existing functionality related to writable streams continues to work as expected. No behavior changes should be observed since this is only removing an unused stub function.

Why make this change?

The stub function in writable-stream.ts was redundant and not being used in the codebase. The actual implementations of getWritable exist in the step and workflow modules. This change simplifies the codebase by removing unused code while preserving the interface definition in a more appropriate location.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Jan 26, 2026

🦋 Changeset detected

Latest commit: 009ca28

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@workflow/core Patch
@workflow/builders Patch
@workflow/cli Patch
@workflow/docs-typecheck Patch
@workflow/next Patch
@workflow/nitro Patch
@workflow/web-shared Patch
workflow Patch
@workflow/astro Patch
@workflow/sveltekit Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/ai Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 26, 2026 •
edited
Loading

🧪 E2E Test Results

❌ Some tests failed

Summary

Passed Failed Skipped Total
✅ ▲ Vercel Production 457 0 38 495
✅ 💻 Local Development 418 0 32 450
✅ 📦 Local Production 418 0 32 450
✅ 🐘 Local Postgres 418 0 32 450
✅ 🪟 Windows 45 0 0 45
❌ 🌍 Community Worlds 31 161 0 192
Total 1787 161 134 2082

❌ Failed Tests

🌍 Community Worlds (161 failed)

mongodb (40 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

redis (40 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

starter (41 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • health check (CLI) - workflow health command reports healthy endpoints
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

turso (40 failed):

  • addTenWorkflow
  • addTenWorkflow
  • should work with react rendering in step
  • promiseAllWorkflow
  • promiseRaceWorkflow
  • promiseAnyWorkflow
  • readableStreamWorkflow
  • hookWorkflow
  • webhookWorkflow
  • sleepingWorkflow
  • nullByteWorkflow
  • workflowAndStepMetadataWorkflow
  • outputStreamWorkflow
  • outputStreamInsideStepWorkflow - getWritable() called inside step functions
  • fetchWorkflow
  • promiseRaceStressTestWorkflow
  • error handling error propagation workflow errors nested function calls preserve message and stack trace
  • error handling error propagation workflow errors cross-file imports preserve message and stack trace
  • error handling error propagation step errors basic step error preserves message and stack trace
  • error handling error propagation step errors cross-file step error preserves message and function names in stack
  • error handling retry behavior regular Error retries until success
  • error handling retry behavior FatalError fails immediately without retries
  • error handling retry behavior RetryableError respects custom retryAfter delay
  • error handling retry behavior maxRetries=0 disables retries
  • error handling catchability FatalError can be caught and detected with FatalError.is()
  • hookCleanupTestWorkflow - hook token reuse after workflow completion
  • concurrent hook token conflict - two workflows cannot use the same hook token simultaneously
  • stepFunctionPassingWorkflow - step function references can be passed as arguments (without closure vars)
  • stepFunctionWithClosureWorkflow - step function with closure variables passed as argument
  • closureVariableWorkflow - nested step functions with closure variables
  • spawnWorkflowFromStepWorkflow - spawning a child workflow using start() inside a step
  • pathsAliasWorkflow - TypeScript path aliases resolve correctly
  • Calculator.calculate - static workflow method using static step methods from another class
  • AllInOneService.processNumber - static workflow method using sibling static step methods
  • ChainableService.processWithThis - static step methods using this to reference the class
  • thisSerializationWorkflow - step function invoked with .call() and .apply()
  • customSerializationWorkflow - custom class serialization with WORKFLOW_SERIALIZE/WORKFLOW_DESERIALIZE
  • pages router addTenWorkflow via pages router
  • pages router promiseAllWorkflow via pages router
  • pages router sleepingWorkflow via pages router

Details by Category

✅ ▲ Vercel Production
App Passed Failed Skipped
✅ astro 41 0 4
✅ example 41 0 4
✅ express 41 0 4
✅ fastify 41 0 4
✅ hono 41 0 4
✅ nextjs-turbopack 44 0 1
✅ nextjs-webpack 44 0 1
✅ nitro 41 0 4
✅ nuxt 41 0 4
✅ sveltekit 41 0 4
✅ vite 41 0 4
✅ 💻 Local Development
App Passed Failed Skipped
✅ astro-stable 41 0 4
✅ express-stable 41 0 4
✅ fastify-stable 41 0 4
✅ hono-stable 41 0 4
✅ nextjs-turbopack-stable 45 0 0
✅ nextjs-webpack-stable 45 0 0
✅ nitro-stable 41 0 4
✅ nuxt-stable 41 0 4
✅ sveltekit-stable 41 0 4
✅ vite-stable 41 0 4
✅ 📦 Local Production
App Passed Failed Skipped
✅ astro-stable 41 0 4
✅ express-stable 41 0 4
✅ fastify-stable 41 0 4
✅ hono-stable 41 0 4
✅ nextjs-turbopack-stable 45 0 0
✅ nextjs-webpack-stable 45 0 0
✅ nitro-stable 41 0 4
✅ nuxt-stable 41 0 4
✅ sveltekit-stable 41 0 4
✅ vite-stable 41 0 4
✅ 🐘 Local Postgres
App Passed Failed Skipped
✅ astro-stable 41 0 4
✅ express-stable 41 0 4
✅ fastify-stable 41 0 4
✅ hono-stable 41 0 4
✅ nextjs-turbopack-stable 45 0 0
✅ nextjs-webpack-stable 45 0 0
✅ nitro-stable 41 0 4
✅ nuxt-stable 41 0 4
✅ sveltekit-stable 41 0 4
✅ vite-stable 41 0 4
✅ 🪟 Windows
App Passed Failed Skipped
✅ nextjs-turbopack 45 0 0
❌ 🌍 Community Worlds
App Passed Failed Skipped
✅ mongodb-dev 3 0 0
❌ mongodb 5 40 0
✅ redis-dev 3 0 0
❌ redis 5 40 0
✅ starter-dev 3 0 0
❌ starter 4 41 0
✅ turso-dev 3 0 0
❌ turso 5 40 0

📋 View full workflow run

@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented Jan 26, 2026 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview, Comment Jan 26, 2026 5:41pm
example-nextjs-workflow-webpack Ready Ready Preview, Comment Jan 26, 2026 5:41pm
example-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-astro-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-express-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-fastify-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-hono-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-nitro-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-nuxt-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-sveltekit-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workbench-vite-workflow Ready Ready Preview, Comment Jan 26, 2026 5:41pm
workflow-docs Ready Ready Preview, Comment Jan 26, 2026 5:41pm

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jan 26, 2026 •
edited
Loading

📊 Benchmark Results

📈 Comparing against baseline from main branch. Green 🟢 = faster, Red 🔺 = slower.

workflow with no steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.036s (-17.5% 🟢) 1.020s (~) 0.983s 10 1.00x
💻 Local Nitro 0.042s (-2.5%) 1.006s (~) 0.964s 10 1.16x
💻 Local Express 0.044s (-3.3%) 1.008s (~) 0.964s 10 1.21x
🐘 Postgres Nitro 0.252s (-0.7%) 1.013s (~) 0.762s 10 6.91x
🐘 Postgres Express 0.311s (+7.3% 🔺) 1.015s (~) 0.704s 10 8.54x
🐘 Postgres Next.js (Turbopack) 0.354s (+147.7% 🔺) 1.021s (~) 0.666s 10 9.74x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 0.630s (-20.4% 🟢) 1.649s (-2.5%) 1.020s 10 1.00x
▲ Vercel Express 0.635s (-28.5% 🟢) 1.666s (-5.5% 🟢) 1.031s 10 1.01x
▲ Vercel Next.js (Turbopack) 0.666s (-11.8% 🟢) 1.749s (-10.9% 🟢) 1.083s 10 1.06x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

workflow with 1 step

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.086s (-1.3%) 2.015s (~) 0.929s 10 1.00x
💻 Local Nitro 1.111s (~) 2.006s (~) 0.894s 10 1.02x
💻 Local Express 1.117s (~) 2.008s (~) 0.891s 10 1.03x
🐘 Postgres Next.js (Turbopack) 2.137s (+10.2% 🔺) 3.020s (+42.6% 🔺) 0.883s 10 1.97x
🐘 Postgres Express 2.143s (+1.1%) 3.017s (~) 0.874s 10 1.97x
🐘 Postgres Nitro 2.143s (-2.1%) 3.015s (~) 0.872s 10 1.97x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 2.819s (-4.6%) 3.719s (+1.4%) 0.900s 10 1.00x
▲ Vercel Next.js (Turbopack) 2.904s (+2.1%) 3.657s (~) 0.752s 10 1.03x
▲ Vercel Nitro 3.065s (+5.8% 🔺) 3.833s (+3.2%) 0.767s 10 1.09x

🔍 Observability: Express | Next.js (Turbopack) | Nitro

workflow with 10 sequential steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 10.608s (-0.7%) 11.018s (~) 0.411s 5 1.00x
💻 Local Nitro 10.816s (~) 11.015s (~) 0.198s 5 1.02x
💻 Local Express 10.854s (~) 11.015s (~) 0.161s 5 1.02x
🐘 Postgres Next.js (Turbopack) 15.454s (+1.3%) 16.038s (~) 0.584s 5 1.46x
🐘 Postgres Express 20.439s (+14.4% 🔺) 21.035s (+15.4% 🔺) 0.596s 5 1.93x
🐘 Postgres Nitro 20.444s (~) 21.030s (~) 0.586s 5 1.93x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 24.191s (-8.1% 🟢) 24.988s (-6.8% 🟢) 0.797s 5 1.00x
▲ Vercel Express 25.077s (~) 26.099s (+1.2%) 1.022s 5 1.04x
▲ Vercel Nitro 25.594s (-2.9%) 26.152s (-2.9%) 0.558s 5 1.06x

🔍 Observability: Next.js (Turbopack) | Express | Nitro

Promise.all with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.368s (-1.7%) 2.017s (~) 0.649s 15 1.00x
💻 Local Nitro 1.379s (-1.0%) 2.005s (~) 0.626s 15 1.01x
💻 Local Express 1.410s (~) 2.007s (~) 0.597s 15 1.03x
🐘 Postgres Next.js (Turbopack) 1.984s (+17.5% 🔺) 2.690s (+31.9% 🔺) 0.706s 12 1.45x
🐘 Postgres Nitro 2.178s (-1.2%) 3.012s (~) 0.835s 10 1.59x
🐘 Postgres Express 2.347s (+15.6% 🔺) 3.017s (+10.0% 🔺) 0.670s 10 1.72x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.933s (-6.1% 🟢) 3.821s (-1.8%) 0.888s 8 1.00x
▲ Vercel Express 3.002s (+3.7%) 3.976s (+8.6% 🔺) 0.974s 8 1.02x
▲ Vercel Next.js (Turbopack) 3.578s (+19.6% 🔺) 4.404s (+21.2% 🔺) 0.826s 7 1.22x

🔍 Observability: Nitro | Express | Next.js (Turbopack)

Promise.all with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 2.280s (-5.5% 🟢) 3.258s (-3.5%) 0.978s 10 1.00x
💻 Local Express 2.440s (-1.5%) 3.032s (~) 0.593s 10 1.07x
💻 Local Nitro 2.444s (-3.8%) 3.047s (+1.0%) 0.603s 10 1.07x
🐘 Postgres Nitro 8.108s (-4.4%) 8.813s (-2.9%) 0.704s 4 3.56x
🐘 Postgres Express 8.492s (-4.2%) 9.302s (-2.6%) 0.809s 4 3.72x
🐘 Postgres Next.js (Turbopack) 11.843s (+7.9% 🔺) 12.710s (+8.7% 🔺) 0.867s 3 5.19x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 3.475s (+8.2% 🔺) 3.957s (+6.5% 🔺) 0.482s 8 1.00x
▲ Vercel Express 3.647s (+2.2%) 4.187s (~) 0.540s 8 1.05x
▲ Vercel Nitro 3.948s (+9.8% 🔺) 4.533s (+10.1% 🔺) 0.584s 7 1.14x

🔍 Observability: Next.js (Turbopack) | Express | Nitro

Promise.race with 10 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 1.397s (~) 2.012s (~) 0.614s 15 1.00x
💻 Local Nitro 1.420s (+1.0%) 2.005s (~) 0.585s 15 1.02x
💻 Local Express 1.423s (~) 2.006s (~) 0.582s 15 1.02x
🐘 Postgres Nitro 2.079s (+2.8%) 2.594s (-3.3%) 0.516s 12 1.49x
🐘 Postgres Express 2.157s (~) 2.598s (~) 0.441s 12 1.54x
🐘 Postgres Next.js (Turbopack) 2.295s (+53.3% 🔺) 2.742s (+36.3% 🔺) 0.447s 11 1.64x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Nitro 2.963s (~) 3.747s (+0.7%) 0.784s 9 1.00x
▲ Vercel Next.js (Turbopack) 3.160s (+8.7% 🔺) 3.844s (+2.9%) 0.684s 8 1.07x
▲ Vercel Express 3.319s (+15.1% 🔺) 4.248s (+13.1% 🔺) 0.929s 8 1.12x

🔍 Observability: Nitro | Next.js (Turbopack) | Express

Promise.race with 25 concurrent steps

💻 Local Development

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 2.339s (-6.5% 🟢) 3.317s (+8.9% 🔺) 0.978s 10 1.00x
💻 Local Nitro 2.517s (-5.0%) 3.014s (~) 0.497s 10 1.08x
💻 Local Express 2.543s (-1.4%) 3.013s (~) 0.469s 10 1.09x
🐘 Postgres Express 11.024s (-4.3%) 11.392s (-2.7%) 0.368s 3 4.71x
🐘 Postgres Nitro 11.619s (+2.1%) 12.091s (~) 0.472s 3 4.97x
🐘 Postgres Next.js (Turbopack) 13.276s (+22.2% 🔺) 13.713s (+20.0% 🔺) 0.438s 3 5.68x

▲ Production (Vercel)

World Framework Workflow Time Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Express 3.367s (+8.0% 🔺) 4.068s (+12.5% 🔺) 0.701s 8 1.00x
▲ Vercel Nitro 3.421s (+8.4% 🔺) 3.898s (+3.2%) 0.477s 8 1.02x
▲ Vercel Next.js (Turbopack) 3.538s (+1.9%) 3.953s (-3.4%) 0.415s 8 1.05x

🔍 Observability: Express | Nitro | Next.js (Turbopack)

Stream Benchmarks (includes TTFB metrics)
workflow with stream

💻 Local Development

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
💻 Local 🥇 Next.js (Turbopack) 0.116s (-16.4% 🟢) 1.003s (~) 0.016s (+2.6%) 1.027s (~) 0.911s 10 1.00x
💻 Local Express 0.179s (-1.2%) 0.992s (~) 0.014s (-6.6% 🟢) 1.021s (~) 0.842s 10 1.55x
💻 Local Nitro 0.180s (-4.8%) 0.993s (~) 0.015s (-14.0% 🟢) 1.021s (~) 0.841s 10 1.55x
🐘 Postgres Next.js (Turbopack) 1.278s (+4.4%) 1.837s (+0.9%) 0.000s (~) 2.017s (~) 0.739s 10 11.03x
🐘 Postgres Express 2.224s (+68.0% 🔺) 2.821s (+57.3% 🔺) 0.000s (NaN%) 3.017s (+49.8% 🔺) 0.793s 10 19.19x
🐘 Postgres Nitro 2.251s (+0.9%) 2.789s (-0.8%) 0.000s (NaN%) 3.014s (~) 0.763s 10 19.42x

▲ Production (Vercel)

World Framework Workflow Time TTFB Slurp Wall Time Overhead Samples vs Fastest
▲ Vercel 🥇 Next.js (Turbopack) 2.996s (+2.2%) 3.223s (+1.1%) 0.478s (+30.4% 🔺) 4.231s (+5.9% 🔺) 1.235s 10 1.00x
▲ Vercel Nitro 3.032s (+2.7%) 3.220s (-2.1%) 1.139s (+290.0% 🔺) 4.893s (+18.0% 🔺) 1.862s 10 1.01x
▲ Vercel Express 3.033s (+5.2% 🔺) 3.375s (+2.1%) 0.911s (+81.6% 🔺) 4.851s (+13.7% 🔺) 1.818s 10 1.01x

🔍 Observability: Next.js (Turbopack) | Nitro | Express

Summary

Fastest Framework by World

Winner determined by most benchmark wins

World 🥇 Fastest Framework Wins
💻 Local Next.js (Turbopack) 8/8
🐘 Postgres Next.js (Turbopack) 4/8
▲ Vercel Nitro 3/8
Fastest World by Framework

Winner determined by most benchmark wins

Framework 🥇 Fastest World Wins
Express 💻 Local 8/8
Next.js (Turbopack) 💻 Local 8/8
Nitro 💻 Local 8/8
Column Definitions
  • Workflow Time: Runtime reported by workflow (completedAt - createdAt) - primary metric
  • TTFB: Time to First Byte - time from workflow start until first stream byte received (stream benchmarks only)
  • Slurp: Time from first byte to complete stream consumption (stream benchmarks only)
  • Wall Time: Total testbench time (trigger workflow + poll for result)
  • Overhead: Testbench overhead (Wall Time - Workflow Time)
  • Samples: Number of benchmark iterations run
  • vs Fastest: How much slower compared to the fastest configuration for this benchmark

Worlds:

  • 💻 Local: In-memory filesystem world (local development)
  • 🐘 Postgres: PostgreSQL database world (local development)
  • ▲ Vercel: Vercel production/preview deployment
  • 🌐 Starter: Community world (local development)
  • 🌐 Turso: Community world (local development)
  • 🌐 MongoDB: Community world (local development)
  • 🌐 Redis: Community world (local development)
  • 🌐 Jazz: Community world (local development)

📋 View full workflow run

@TooTallNate Graphite App
Copy link
Copy Markdown
Member Author

TooTallNate commented Jan 26, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@TooTallNate TooTallNate marked this pull request as ready for review January 26, 2026 17:40
Copilot AI review requested due to automatic review settings January 26, 2026 17:40
Copilot AI reviewed Jan 26, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes an unused stub implementation of getWritable that was left over from when there were separate default vs. "step" context export conditions. The cleanup consolidates the codebase by moving the interface definition to a more appropriate location.

Changes:

  • Removed the standalone writable-stream.ts file containing an unused stub implementation
  • Moved WorkflowWritableStreamOptions interface to step/writable-stream.ts where it's used by the actual implementation
  • Updated import path in workflow/writable-stream.ts to reference the interface from its new location

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/core/src/writable-stream.ts Deleted unused stub file containing the getWritable stub function and interface definition
packages/core/src/step/writable-stream.ts Added WorkflowWritableStreamOptions interface definition, previously imported from deleted file
packages/core/src/workflow/writable-stream.ts Updated import to reference WorkflowWritableStreamOptions from step/writable-stream.ts
.changeset/quick-mammals-kneel.md Added changeset documenting the removal of unused code

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@pranaygp pranaygp merged commit 00c7961 into main Jan 26, 2026
99 checks passed
@pranaygp pranaygp deleted the 01-26-remove_unused_getwritable_stub_function branch January 26, 2026 19:13
@vercel-release-bot vercel-release-bot mentioned this pull request Jan 23, 2026
Merged
pranaygp added a commit that referenced this pull request Jan 28, 2026
@pranaygp
Merge remote-tracking branch 'origin/main' into add-claude-code-skill…
6006ba7 
…s-and-commands

* origin/main:
  fix(@workflow/ai): support provider-executed tools (AI SDK v6) (#734)
  Publish "workflow" and "@workflow/core" package versions in sync (#870)
  Add SDK version to workflow run executionContext for observability (#868)
  Allow recreateRun to accept an optional deploymentId parameter (#869)
  Add support for top-level `using` declarations inside of step / workflow functions (#866)
  docs: URL in docs was missing the docs/ prefix, 404 errors (#852)
  Add "classes" object to `manifest.json` file (#864)
  Fix Nest workbench app build (#865)
  Ignore Astro on local dev tests for source map e2e tests (#863)
  Enable custom class serialization transformations for "client" mode (#860)
  Submit request bodies with CBOR encoding (#844)
  [world-vercel] Update queue to use VQS v3 API (#799)
  NestJS framework support (#840)
  Fix resolve hook theming and token fetching. (#856)
  docs: rename Control Flow Patterns to Common Patterns and add new content (#846)
  docs: revamp World documentation pages (#763)
  Remove unused `getWritable` stub function (#855)

# Conflicts:
#	packages/core/package.json
#	pnpm-lock.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@pranaygp pranaygp pranaygp approved these changes

@VaguelySerious VaguelySerious Awaiting requested review from VaguelySerious

@karthikscale3 karthikscale3 Awaiting requested review from karthikscale3

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TooTallNate @pranaygp