-
Notifications
You must be signed in to change notification settings - Fork 264
[core] Refactor getWorld interface to be asynchronous #942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
26 commits
Select commit
Hold shift + click to select a range
734b4df
[core] Make getWorld interface asynchronous
VaguelySerious f82f218
Fixes
VaguelySerious a0d8202
Fixes
VaguelySerious 924314c
Merge branch 'main' into peter/async-world
VaguelySerious b086650
Fix: Race condition in getWorld() and getWorldHandlers() allows multi…
vercel[bot] efff295
Maybe fix tests
VaguelySerious 1d67f3f
Merge branch 'main' into peter/async-world
VaguelySerious 15193e8
Fix build
VaguelySerious 1871507
Revert "Fix build"
VaguelySerious fba0775
Merge branch 'main' into peter/async-world
VaguelySerious 4dcfbc2
Fix build and test errors after merge
VaguelySerious b16728c
Address PR review feedback
VaguelySerious 81a548b
Fix: try require() before dynamicImport for custom world modules
VaguelySerious dec7335
merge: resolve conflicts with main
VaguelySerious 4300ff0
fix: await getWorld() in resilient start e2e test
VaguelySerious a5b0e82
fix: don't encrypt hook metadata so webhook handler can read it
VaguelySerious 8345fcf
fix: update encryption capability minVersion after v5 version reset
VaguelySerious 8a5acb5
fix: update capabilities test for new encryption minVersion
VaguelySerious e129d92
revert: keep encrypting hook metadata in suspension handler
VaguelySerious 9220639
fix: sync package versions to 5.0.0-beta.0 and revert capabilities ch…
VaguelySerious 1c94485
Merge branch 'main' into peter/async-world
VaguelySerious 3fa3b6a
Flip module resolution order: dynamicImport() before require()
VaguelySerious bd2a0d8
Merge main into peter/async-world
VaguelySerious 1c663f6
Fix merge artifacts: duplicate import and missing features field
VaguelySerious 9cb5a8b
Merge branch 'main' into peter/async-world
VaguelySerious 2653faf
docs: document async getWorld() and update World SDK skill
VaguelySerious File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| --- | ||
| "@workflow/core": patch | ||
| "@workflow/cli": patch | ||
| --- | ||
|
|
||
| **BREAKING CHANGE**: Make `getWorld` and `createWorld` asynchronous to support ESM dynamic imports for custom world modules. All callers must now `await getWorld()`. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.