Allow @ in workflow names to support scoped packages#990
Merged
TooTallNate merged 2 commits intoFeb 12, 2026
Conversation
🦋 Changeset detectedLatest commit: 9679dff The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
🧪 E2E Test Results❌ Some tests failed Summary
❌ Failed Tests🌍 Community Worlds (42 failed)mongodb (1 failed):
turso (41 failed):
Details by Category✅ ▲ Vercel Production
✅ 💻 Local Development
✅ 📦 Local Production
✅ 🐘 Local Postgres
✅ 🪟 Windows
❌ 🌍 Community Worlds
✅ 📋 Other
|
Contributor
📊 Benchmark Results
workflow with no steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) workflow with 1 step💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro workflow with 10 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 25 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express workflow with 50 sequential steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Next.js (Turbopack) | Express Promise.all with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro Promise.all with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.all with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Nitro | Express | Next.js (Turbopack) Promise.race with 10 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Promise.race with 25 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Nitro | Next.js (Turbopack) Promise.race with 50 concurrent steps💻 Local Development
▲ Production (Vercel)
🔍 Observability: Next.js (Turbopack) | Nitro | Express Stream Benchmarks (includes TTFB metrics)workflow with stream💻 Local Development
▲ Production (Vercel)
🔍 Observability: Express | Next.js (Turbopack) | Nitro SummaryFastest Framework by WorldWinner determined by most benchmark wins
Fastest World by FrameworkWinner determined by most benchmark wins
Column Definitions
Worlds:
|
Contributor
Contributor
There was a problem hiding this comment.
Pull request overview
This PR intends to allow @ in workflow names so they can align with scoped npm package naming (e.g., @scope/pkg), but the diff provided only adds a Changesets entry and does not include the corresponding runtime validation change.
Changes:
- Added a patch changeset for
@workflow/coredescribing support for@in workflow names.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Additional Suggestion:
SAFE_WORKFLOW_NAME_PATTERN regex rejects @ characters, causing getWorkflowQueueName() to throw for any workflow using versioned or scoped npm packages (e.g., workflow//mypackage@1.0.0//handleOrder or workflow//@myorg/tasks@2.0.0//processOrder).
karthikscale3
previously approved these changes
Feb 10, 2026
pranaygp
reviewed
Feb 12, 2026
Contributor
pranaygp
left a comment
pranaygp
left a comment
There was a problem hiding this comment.
Good change overall — the regex update, error message, tests, and step-handler refactoring all look correct. A couple of minor nits below.
Contributor
|
Note: Step names have the same raw-interpolation issue that this PR fixes for workflow names. At `__wkf_step_${queueItem.stepName}`There's no Lower priority since step names come from compiler-generated function names rather than npm package names, but worth addressing for completeness. |
TooTallNate
force-pushed
the
02-10-allow_in_workflow_names_to_support_scoped_packages
branch
from
5cb6def to
9679dff
Compare
pranaygp
approved these changes
Feb 12, 2026
Contributor
pranaygp
left a comment
pranaygp
left a comment
There was a problem hiding this comment.
Looks good — the regex update, error message, tests, and step-handler refactoring are all solid. The JSDoc comment has been updated too. Approving.
TooTallNate
deleted the
02-10-allow_in_workflow_names_to_support_scoped_packages
branch
This was referenced Feb 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow
@in workflow names to support scoped packagesWhat changed?
Modified the workflow core package to allow the
@character in workflow names, enabling support for scoped npm packages (e.g.,@workflow/core).How to test?
Create a workflow with a name that includes the
@character, such as@my-org/workflow-name, and verify that it works correctly without validation errors.Why make this change?
This change enables users to name their workflows after scoped npm packages, which follow the
@scope/package-nameconvention. Previously, the@character was likely disallowed in workflow names, preventing users from aligning workflow names with their scoped package names.