Skip to content

Disallow navigation to a BetweenBaseAndScripts position when base is placeholder #101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Happypig375 merged 1 commit into from
Nov 24, 2019
Merged

Disallow navigation to a BetweenBaseAndScripts position when base is placeholder #101

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions CSharpMath.Editor/Keyboards/MathKeyboard.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,14 +226,18 @@ void MoveCursorLeft() {
}
if (_insertionIndex is null)
throw new InvalidOperationException($"{nameof(_insertionIndex)} is null.");
if (MathList.AtomAt(_insertionIndex) is null &&
MathList.AtomAt(_insertionIndex?.Previous)?.AtomType is MathAtomType.Placeholder)
if (_insertionIndex.FinalSubIndexType is MathListSubIndexType.BetweenBaseAndScripts) {
var prevInd = _insertionIndex.LevelDown();
if (MathList.AtomAt(prevInd).AtomType is MathAtomType.Placeholder)
_insertionIndex = prevInd;
} else if (MathList.AtomAt(_insertionIndex) is null && MathList.AtomAt(_insertionIndex?.Previous)?.AtomType is MathAtomType.Placeholder)
_insertionIndex = _insertionIndex.Previous; // Skip right side of placeholders when end of line
}
void MoveCursorRight() {
if (_insertionIndex is null)
throw new InvalidOperationException($"{nameof(_insertionIndex)} is null.");
switch (MathList.AtomAt(_insertionIndex)) {
var currentAtom = MathList.AtomAt(_insertionIndex);
switch (currentAtom) {
case null: //After Count
var levelDown = _insertionIndex.LevelDown();
switch (_insertionIndex.FinalSubIndexType) {
Expand Down Expand Up @@ -300,6 +304,8 @@ void MoveCursorRight() {
}
if (_insertionIndex is null)
throw new InvalidOperationException($"{nameof(_insertionIndex)} is null.");
if (_insertionIndex.FinalSubIndexType is MathListSubIndexType.BetweenBaseAndScripts && currentAtom?.AtomType is MathAtomType.Placeholder)
MoveCursorRight();
}

void DeleteBackwards() {
Expand Down