Specify shell to make sure macOS make respects PATH#267
Merged
mcous merged 2 commits intoviamrobotics:mainfrom Jun 5, 2023
Merged
Specify shell to make sure macOS make respects PATH#267mcous merged 2 commits intoviamrobotics:mainfrom
make respects PATH#267mcous merged 2 commits intoviamrobotics:mainfrom
Conversation
mcous
changed the title
make respects PATH
pstrutz
added a commit
to pstrutz/api
that referenced
this pull request
Jun 23, 2023
…#267) Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
SHELL := bashto the Makefile because without it macOSmakedoes not respectexport PATH. Anecdotally, this is not the first time I've seen this. For fun, also see this Stack Overflow post from 2014!This is probably a good thing to do by default in our Makefiles anyway. For example, it's part of this style guide's default prologue. From that styleguide, setting
.SHELLOPTIONSseems like an potentially good move to consider, too