BUG: unable to access any nested aspects from imported namespace

[michaelBelsanti]

Description

https://github.com/michaelBelsanti/bogus-den

       error: attribute '_' missing
       at /nix/store/1m2c8wls1ms8rzrfx37jdp9a3wvv066s-source/modules/bug.nix:7:32:
            6|   den.hosts.x86_64-linux.good.users.quasi = { };
            7|   den.aspects.bad.includes = [ styx.services._.ssh ];
             |                                ^
            8|   den.aspects.good.includes = [ styx.performance ];

These aspects work fine when being used within the original flake, but do not work when imported by another. Aspects that aren't nested work fine.

See: #112

[michaelBelsanti]

This seems to still be an issue. Including a nested aspect is still throwing an error in the reproduction: https://github.com/michaelBelsanti/bogus-den/tree/namespace

nu ➜ nixos-rebuild-ng build --flake .#bad
building the system configuration...
error:
       … while calling the 'seq' builtin
         at /nix/store/ndig4f4dx8bmrmyr5vfm19g02r9l9ggm-source/lib/modules.nix:361:18:
          360|         options = checked options;
          361|         config = checked (removeAttrs config [ "_module" ]);
             |                  ^
          362|         _module = checked (config._module);

       … while evaluating a branch condition
         at /nix/store/ndig4f4dx8bmrmyr5vfm19g02r9l9ggm-source/lib/modules.nix:297:9:
          296|       checkUnmatched =
          297|         if config._module.check && config._module.freeformType == null && merged.unmatchedDefns != [ ] then
             |         ^
          298|           let

       … while evaluating the option `den.aspects.bad.__functor.<function body>.<function body>.__functor.<function body>.<function body>.includes':

       … while evaluating definitions from `<unknown-file>':

       … while evaluating the option `den.aspects.bad.__functor.<function body>.<function body>.includes':

       … while evaluating definitions from `/nix/store/qlg1nbcj59rsgxwf38m5lasxahshc6aj-source/modules/aspects/definition.nix':

       … while evaluating the option `den.aspects.bad.includes':

       … while evaluating definitions from `/nix/store/hsskrhb4f18rvf9wq7px1bf5wcsm4g7h-source/modules/bug.nix':

       (stack trace truncated; use '--show-trace' to show the full, detailed trace)

       error: attribute '_' missing
       at /nix/store/hsskrhb4f18rvf9wq7px1bf5wcsm4g7h-source/modules/bug.nix:11:32:
           10|   den.hosts.x86_64-linux.good.users.quasi = { };
           11|   den.aspects.bad.includes = [ styx.services._.ssh ];
             |                                ^
           12|   den.aspects.good.includes = [ styx.performance ];
Command 'nix --extra-experimental-features 'nix-command flakes' build --print-out-paths '.#nixosConfigurations."bad".config.system.build.toplevel'' returned non-zero exit status 1.

[vic]

Oh, right, can you try using styx.services._.ssh => styx.services.provides.ssh ?

My first guess is this is more related to _ not being an alias for provides for attributes that are read from a consumer flake.

Does <styx/services/ssh> works on the consumer flake? I guess it will because it expands to .provides. and not ._..

[vic]

Thanks for reporting again.

[michaelBelsanti]

It's unable to access the provides attribute as well

       error: attribute 'provides' missing
       at /nix/store/mwfwghcw48yd9i9826bldg8vjaz7r7r3-source/modules/bug.nix:11:32:
           10|   den.hosts.x86_64-linux.good.users.quasi = { };
           11|   den.aspects.bad.includes = [ styx.services.provides.ssh ];
             |                                ^
           12|   den.aspects.good.includes = [ styx.performance ];
Command 'nix --extra-experimental-features 'nix-command flakes' build --print-out-paths '.#nixosConfigurations."bad".config.system.build.toplevel'' returned non-zero exit status 1.

As you'd expect, this means the angle brackets syntax also fails.

[vic]

Ok, will have a look at this tonight, I'll try to make your bogus repo to work and then add tests we are missing in den.

[michaelBelsanti]

Sounds good. I have a little free time this morning, I'll spend some time reading through how the namespaces are imported.

[vic]

@michaelBelsanti can you try with this commit? -already in trunk- Using it flake check succeeds on your bogus repo.

[michaelBelsanti]

That definitely improved things, I can access aspects nested once, but strangely I can't reach further nested aspects. Looking through the flake in a repl, they're available being accessed through the input, but somehow being lost when the namespace is imported.

nix-repl> debug.den.ful.styx.services._.ssh._.server
error: attribute '_' missing
       at «string»:1:1:
            1| debug.den.ful.styx.services._.ssh._.server
             | ^

nix-repl> debug.den.ful.styx.services._.ssh
{
  __functionArgs = { ... };
  __functor = «lambda __functor @ /nix/store/55z53i8nflvx4y9662rc0b6xb9y43b66-source/lib/types.nix:1093:15»;
}

nix-repl> inputs.nixconfig.denful.styx.services._.ssh._.server
{
  _ = { ... };
  __functor = { ... };
  description = "Aspect server";
  includes = [ ... ];
  modules = { ... };
  name = "server";
  nixos = { ... };
  provides = «repeated»;
  resolve = { ... };
}

For now at least, I can just remove the service prefix from some things. I was considering doing that anyways.

I'm really struggling to see why this would be, especially since the issue doesn't occur in the test.

I would assume this has to do with the type differences between den.ful and denful.

[vic]

Is the source nixconfig repository also updated with latest den ?

[vic]

when I tested, I was also able to get the nested ssh client aspect from the input.

warning: Git tree '/home/vic/hk/bogus-den' is dirty
Loading installable 'git+file:///home/vic/hk/bogus-den#'...
Added 11 variables.
apps, checks, devShells, formatter, legacyPackages, modules, nixosConfigurations, nixosModules, overlays, packages, tests
nix-repl> :lf .
Added 22 variables.
_type, apps, checks, devShells, dirtyRev, dirtyShortRev, formatter, inputs, lastModified, lastModifiedDate, legacyPackages, modules, narHash, nixosConfigurations, nixosModules, outPath, outputs, overlays, packages, sourceInfo
... and 2 more; view with :ll

nix-repl> inputs.nixconfig.denful.styx.services._.ssh._.client
{
  _ = { ... };
  __functor = { ... };
  description = "Aspect client";
  homeManager = { ... };
  includes = [ ... ];
  modules = { ... };
  name = "client";
  provides = «repeated»;
  resolve = { ... };
}