Support for inheriting BaseURL and alternate BaseURLs#17
Conversation
| timeline: undefined | ||
| } | ||
| }, { | ||
| attributes: { |
There was a problem hiding this comment.
The subtitle representation gets duplicated here because of the way alternate base urls are generated. There are 2 parent level base urls, so we resolve this base url wrt both of those, however since this base url is absolute, we resolve the absolute url twice.
This shouldn't really be an issue because in organizeVttPlaylists we skip vtt playlists that we already have a playlist for that language.
If we want to not produce these duplicates, then the base url creation logic will have to account for absolute urls lower down the tree and filter out duplicates. Thoughts?
There was a problem hiding this comment.
We may have more complicated vtt playlist support in the future that might involve different tracks with the same language and type (maybe). Perhaps dedupe in organizeVttPlaylists if we know it will always be unsegmented?
There was a problem hiding this comment.
Actually let's leave that as a TODO and get to it when we need to
There was a problem hiding this comment.
Ya we will probably want to dedupe based on AdaptionSet ID since that seems to be where the lang is defined
2 participants
No description provided.