fix(loading-spinner): border size customization#8369
Merged
dzianis-dashkevich merged 1 commit intovideojs:mainfrom Dec 4, 2023
Merged
fix(loading-spinner): border size customization#8369dzianis-dashkevich merged 1 commit intovideojs:mainfrom
dzianis-dashkevich merged 1 commit intovideojs:mainfrom
Conversation
Allows to change the border size of the `loading-spinner` component without having to reflect the border size in the pseudo-element margin. - uses display `flex` to facilitate centering of pseudo-elements - deletes the pseudo-elements `margin`
mister-ben
changed the title
Codecov Report
@@ Coverage Diff @@
## main #8369 +/- ##
==========================================
- Coverage 82.71% 82.68% -0.03%
==========================================
Files 113 113
Lines 7578 7578
Branches 1821 1821
==========================================
- Hits 6268 6266 -2
- Misses 1310 1312 +2 see 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mister-ben
approved these changes
Aug 11, 2023
Contributor
mister-ben
left a comment
mister-ben
left a comment
There was a problem hiding this comment.
We can ignore codecov here, it's wrong
dzianis-dashkevich
approved these changes
Dec 4, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Allows to change the border size of the
loading-spinnercomponent without having to reflect the border size in pseudo-element's margin.Screencast.from.19.07.23.18.08.10.webm
Specific Changes proposed
flexto facilitate centering of pseudo-elementsmarginRequirements Checklist