Skip to content

fix: Don't request fullscreen from document PIP window#8881

Merged
mister-ben merged 2 commits intovideojs:mainfrom
mister-ben:fix-dpip-dclick
Oct 6, 2024
Merged

fix: Don't request fullscreen from document PIP window#8881
mister-ben merged 2 commits intovideojs:mainfrom
mister-ben:fix-dpip-dclick

Conversation

@mister-ben
Copy link
Contributor

Description

Double clicking the document pip window requests fullscreen but this fails. The gesture on the pip window can't initiate fullscreen.
Fixes #8877

Specific Changes proposed

Change the default double click action to just exit pip. This is the same behaviour as before without the error, as requestFullScreen() calls exitPictureInPicture();

Requirements Checklist

  • Feature implemented / Bug fixed
  • If necessary, more likely in a feature request than a bug fix
    • Change has been verified in an actual browser (Chrome, Firefox, IE)
    • Unit Tests updated or fixed
    • Docs/guides updated
    • Example created (starter template on JSBin)
    • Has no DOM changes which impact accessiblilty or trigger warnings (e.g. Chrome issues tab)
    • Has no changes to JSDoc which cause npm run docs:api to error
  • Reviewed by Two Core Contributors

@codecov
Copy link

codecov bot commented Oct 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.21%. Comparing base (b1dee92) to head (8d5fc26).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8881   +/-   ##
=======================================
  Coverage   83.21%   83.21%           
=======================================
  Files         120      120           
  Lines        8066     8068    +2     
  Branches     1937     1938    +1     
=======================================
+ Hits         6712     6714    +2     
  Misses       1354     1354           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Co-authored-by: Gary Katsevman <git@gkatsev.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Double clicking document PiP window produces an error "Uncaught (in promise) TypeError: Fullscreen is not supported"

2 participants