chore: Enable supply chain security through npm provenance attestation#8911
Merged
adrums86 merged 4 commits intovideojs:mainfrom Feb 5, 2025
Merged
chore: Enable supply chain security through npm provenance attestation#8911adrums86 merged 4 commits intovideojs:mainfrom
adrums86 merged 4 commits intovideojs:mainfrom
Conversation
- Configure GitHub Actions workflow for secure publishing - Enable automatic provenance generation during npm publish - Add integrity verification through Sigstore transparency logs
|
💖 Thanks for opening this pull request! 💖 Things that will help get your PR across the finish line:
We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can. |
dzianis-dashkevich
approved these changes
Nov 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8911 +/- ##
=======================================
Coverage 83.72% 83.72%
=======================================
Files 120 120
Lines 8110 8110
Branches 1949 1949
=======================================
Hits 6790 6790
Misses 1320 1320 ☔ View full report in Codecov by Sentry. |
Contributor
Author
|
any update? Do you guys want to merge it? |
Contributor
|
Sorry for the delay @pupapaik, working through getting a minor version of VJS out today. Merging this now. Thanks for your contribution! |
adrums86
approved these changes
Feb 5, 2025
|
Congrats on merging your first pull request! 🎉🎉🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Following the recent Lottie-Player supply chain attack, it's crucial to enhance package security. NPM provenance provides cryptographic proof that this package was built from this repository using GitHub Actions, making supply chain attacks significantly harder. More info in my blog post https://medium.com/exaforce/npm-provenance-the-missing-security-layer-in-popular-javascript-libraries-b50107927008
Specific Changes proposed
Changes the workflow github to publish provenance attestation on https://www.npmjs.com/package/video.js
Requirements Checklist
npm run docs:apito error