Skip to content

fix(nix): drop inherited source patch - #10

Merged
vimoppa merged 1 commit into
mainfrom
feature/fix-nix-inherited-postpatch
Jul 28, 2026
Merged

fix(nix): drop inherited source patch#10
vimoppa merged 1 commit into
mainfrom
feature/fix-nix-inherited-postpatch

Conversation

@vimoppa

@vimoppa vimoppa commented Jul 28, 2026

Copy link
Copy Markdown
Owner

What Changed

  • Clear nixpkgs’ source-specific postPatch after replacing the package source with this repository.
  • Keep the moving main source buildable when upstream changes apps/web/vite.config.ts.

Why

The package overrides nixpkgs’ pinned T3Code source but was still inheriting a patch written for that pinned revision. After the Vite host setup changed on main, substituteInPlace --replace-fail no longer matched and every Nix build stopped during patchPhase.

The inherited patch only changes development-server host fallback behavior and is not required for the packaged desktop build. An empty override is required here; deleting the override would restore the stale inherited hook.

Validation

  • nix build .#t3code --no-link --max-jobs 1
  • Confirmed the packaged app bundle and executable exist
  • plutil -lint on the packaged Info.plist
  • git diff --check

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes (not applicable)
  • I included a video for animation/interaction changes (not applicable)

@github-actions github-actions Bot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XS labels Jul 28, 2026
@vimoppa vimoppa self-assigned this Jul 28, 2026
@vimoppa
vimoppa merged commit b745483 into main Jul 28, 2026
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS vouch:trusted PR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant