fix(nix): drop inherited source patch - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
postPatchafter replacing the package source with this repository.mainsource buildable when upstream changesapps/web/vite.config.ts.Why
The package overrides nixpkgs’ pinned T3Code source but was still inheriting a patch written for that pinned revision. After the Vite host setup changed on
main,substituteInPlace --replace-failno longer matched and every Nix build stopped duringpatchPhase.The inherited patch only changes development-server host fallback behavior and is not required for the packaged desktop build. An empty override is required here; deleting the override would restore the stale inherited hook.
Validation
nix build .#t3code --no-link --max-jobs 1plutil -linton the packagedInfo.plistgit diff --checkChecklist